Commit 09622d6
authored
fix(replay): Consider more things as DOM mutations for dead clicks (#13518)
Previously, we only considered `Mutation` style changes of rrweb as "DOM
mutations" for dead click detection.
However, after closer inspection, there are also some other types of
changes that we may consider as DOM mutations. By including these we can
hopefully reduce some false positives.
Not quite sure how to test this 🤔 It's probably also OK to just ship
this, as the worst-case scenario is that we have some false-negatives
and do not capture certain things, but our general goal here is to be
rather on the cautious side, so I think that is acceptable.
Possibly fixes
#97551 parent 03d67c9 commit 09622d6
File tree
2 files changed
+13
-2
lines changed- packages/replay-internal/src/coreHandlers
2 files changed
+13
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
43 | 54 | | |
44 | 55 | | |
45 | 56 | | |
| |||
324 | 335 | | |
325 | 336 | | |
326 | 337 | | |
327 | | - | |
| 338 | + | |
328 | 339 | | |
329 | 340 | | |
330 | 341 | | |
| |||
0 commit comments