fix(feedback): Fix an issue where, if removeFromDom() is called it might throw

Author: ryan953

packages/feedback/src/core/components/Actor.ts

@@ -1,6 +1,8 @@
+import { DEBUG_BUILD } from 'src/util/debug-build';
 import { DOCUMENT, TRIGGER_LABEL } from '../../constants';
 import { createActorStyles } from './Actor.css';
 import { FeedbackIcon } from './FeedbackIcon';
+import { logger } from '@sentry/core';
 
 export interface ActorProps {
   triggerLabel: string;
@@ -46,8 +48,16 @@ export function Actor({ triggerLabel, triggerAriaLabel, shadow, styleNonce }: Ac
       shadow.appendChild(el);
     },
     removeFromDom(): void {
-      shadow.removeChild(el);
-      shadow.removeChild(style);
+      try {
+        el.remove();
+        style.remove();
+      } catch {
+        DEBUG_BUILD &&
+        logger.error(
+          '[Feedback] Error when trying to remove Actor from the DOM. It is not appended to the DOM yet!',
+        );
+        throw new Error('[Feedback] Actor is not appended to DOM, nothing to remove.');
+      }
     },
     show(): void {
       el.ariaHidden = 'false';

packages/feedback/src/modal/integration.tsx

@@ -5,6 +5,8 @@ import * as hooks from 'preact/hooks';
 import { DOCUMENT } from '../constants';
 import { Dialog } from './components/Dialog';
 import { createDialogStyles } from './components/Dialog.css';
+import { DEBUG_BUILD } from 'src/util/debug-build';
+import { logger } from '@sentry/core';
 
 function getUser(): User | undefined {
   const currentUser = getCurrentScope().getUser();
@@ -44,8 +46,14 @@ export const feedbackModalIntegration = ((): FeedbackModalIntegration => {
           }
         },
         removeFromDom(): void {
-          shadowRoot.removeChild(el);
-          shadowRoot.removeChild(style);
+          try {
+            el.remove();
+            style.remove();
+          } catch {
+            DEBUG_BUILD &&
+              logger.error('[Feedback] Error when trying to remove Modal from the DOM. It is not appended to the DOM yet!');
+            throw new Error('[Feedback] Modal is not appended to DOM, nothing to remove.');
+          }
           DOCUMENT.body.style.overflow = originalOverflow;
         },
         open() {