Skip to content

Commit 361b9d8

Browse files
committed
explicitly await async operations in browser integration tests
1 parent 753b454 commit 361b9d8

File tree

3 files changed

+5
-5
lines changed
  • packages/integration-tests/suites/tracing

3 files changed

+5
-5
lines changed

packages/integration-tests/suites/tracing/browsertracing/backgroundtab-pageload/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ sentryTest('should finish pageload transaction when the page goes background', a
99

1010
await page.goto(url);
1111

12-
page.click('#go-background');
12+
void page.click('#go-background');
1313

1414
const pageloadTransaction = await getFirstSentryEnvelopeRequest<Event>(page);
1515

packages/integration-tests/suites/tracing/metrics/web-vitals-fid/test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ sentryTest('should capture a FID vital.', async ({ browserName, getLocalTestPath
1212

1313
const url = await getLocalTestPath({ testDir: __dirname });
1414

15-
page.goto(url);
15+
await page.goto(url);
1616
// To trigger FID
17-
page.click('#fid-btn');
17+
await page.click('#fid-btn');
1818

1919
const eventData = await getFirstSentryEnvelopeRequest<Event>(page);
2020

packages/integration-tests/suites/tracing/metrics/web-vitals-lcp/test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ sentryTest('should capture a LCP vital with element details.', async ({ browserN
1414
);
1515

1616
const url = await getLocalTestPath({ testDir: __dirname });
17-
page.goto(url);
17+
await page.goto(url);
1818

1919
// Force closure of LCP listener.
20-
page.click('body');
20+
await page.click('body');
2121
const eventData = await getFirstSentryEnvelopeRequest<Event>(page);
2222

2323
expect(eventData.measurements).toBeDefined();

0 commit comments

Comments
 (0)