ref(utils): Stop setting transaction in requestDataIntegration

This is not really necessary anymore - it only sets this on transaction events, and those get the `transaction` in different places already anyhow.

With this, we can also actually remove some other stuff. One method is exported from utils but not otherwise used, we can also drop this in v9.

Finally, this was also the only place that used `route` on the request, so we can also get rid of this in `remix`, which is weird anyhow because we set it for errors there but don't even use it for them.

Author: mydea

packages/remix/src/utils/errors.ts

@@ -1,12 +1,5 @@
 import type { AppData, DataFunctionArgs, EntryContext, HandleDocumentRequestFunction } from '@remix-run/node';
-import {
-  captureException,
-  getActiveSpan,
-  getClient,
-  getRootSpan,
-  handleCallbackErrors,
-  spanToJSON,
-} from '@sentry/core';
+import { captureException, getClient, handleCallbackErrors } from '@sentry/core';
 import type { Span } from '@sentry/types';
 import { addExceptionMechanism, isPrimitive, logger, objectify } from '@sentry/utils';
 import { DEBUG_BUILD } from './debug-build';
@@ -61,19 +54,9 @@ export async function captureRemixServerException(
   const objectifiedErr = objectify(err);
 
   captureException(isResponse(objectifiedErr) ? await extractResponseError(objectifiedErr) : objectifiedErr, scope => {
-    const activeSpan = getActiveSpan();
-    const rootSpan = activeSpan && getRootSpan(activeSpan);
-    const activeRootSpanName = rootSpan ? spanToJSON(rootSpan).description : undefined;
-
     scope.setSDKProcessingMetadata({
       request: {
         ...normalizedRequest,
-        // When `route` is not defined, `RequestData` integration uses the full URL
-        route: activeRootSpanName
-          ? {
-              path: activeRootSpanName,
-            }
-          : undefined,
       },
     });
 

packages/remix/src/utils/instrumentServer.ts

@@ -314,9 +314,6 @@ function wrapRequestHandler(
       isolationScope.setSDKProcessingMetadata({
         request: {
           ...normalizedRequest,
-          route: {
-            path: name,
-          },
         },
       });
 

packages/utils/src/requestdata.ts

@@ -21,7 +21,6 @@ import { getClientIPAddress, ipHeaderNames } from './vendor/getIpAddress';
 const DEFAULT_INCLUDES = {
   ip: false,
   request: true,
-  transaction: true,
   user: true,
 };
 const DEFAULT_REQUEST_INCLUDES = ['cookies', 'data', 'headers', 'method', 'query_string', 'url'];
@@ -35,6 +34,7 @@ export type AddRequestDataToEventOptions = {
   include?: {
     ip?: boolean;
     request?: boolean | Array<(typeof DEFAULT_REQUEST_INCLUDES)[number]>;
+    /** @deprecated This option will be removed in v9. It does not do anything anymore, the `transcation` is set in other places. */
     transaction?: boolean | TransactionNamingScheme;
     user?: boolean | Array<(typeof DEFAULT_USER_INCLUDES)[number]>;
   };
@@ -67,6 +67,7 @@ export type TransactionNamingScheme = 'path' | 'methodPath' | 'handler';
  *                used instead of the request's route)
  *
  * @returns A tuple of the fully constructed transaction name [0] and its source [1] (can be either 'route' or 'url')
+ * @deprecated This method will be removed in v9. It is not in use anymore.
  */
 export function extractPathForTransaction(
   req: PolymorphicRequest,
@@ -102,23 +103,6 @@ export function extractPathForTransaction(
   return [name, source];
 }
 
-function extractTransaction(req: PolymorphicRequest, type: boolean | TransactionNamingScheme): string {
-  switch (type) {
-    case 'path': {
-      return extractPathForTransaction(req, { path: true })[0];
-    }
-    case 'handler': {
-      return (req.route && req.route.stack && req.route.stack[0] && req.route.stack[0].name) || '<anonymous>';
-    }
-    case 'methodPath':
-    default: {
-      // if exist _reconstructedRoute return that path instead of route.path
-      const customRoute = req._reconstructedRoute ? req._reconstructedRoute : undefined;
-      return extractPathForTransaction(req, { path: true, method: true, customRoute })[0];
-    }
-  }
-}
-
 function extractUserData(
   user: {
     [key: string]: unknown;
@@ -379,12 +363,6 @@ export function addRequestDataToEvent(
     }
   }
 
-  if (include.transaction && !event.transaction && event.type === 'transaction') {
-    // TODO do we even need this anymore?
-    // TODO make this work for nextjs
-    event.transaction = extractTransaction(req, include.transaction);
-  }
-
   return event;
 }