Skip to content

Commit 6865b6e

Browse files
committed
Fix dedup test and lint
1 parent 270ce53 commit 6865b6e

File tree

2 files changed

+26
-16
lines changed

2 files changed

+26
-16
lines changed

packages/core/test/lib/integrations/inboundfilters.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { EventProcessor, Event } from '@sentry/types';
1+
import { Event, EventProcessor } from '@sentry/types';
22

33
import { InboundFilters, InboundFiltersOptions } from '../../../src/integrations/inboundfilters';
44

packages/integrations/test/dedupe.test.ts

+25-15
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,40 @@
1+
import { Event } from '@sentry/types';
2+
13
import { _shouldDropEvent } from '../src/dedupe';
24

35
/** JSDoc */
46
function clone<T>(data: T): T {
57
return JSON.parse(JSON.stringify(data));
68
}
79

8-
const messageEvent = {
10+
const messageEvent: Event = {
911
fingerprint: ['MrSnuffles'],
1012
message: 'PickleRick',
11-
stacktrace: {
12-
frames: [
13-
{
14-
colno: 1,
15-
filename: 'filename.js',
16-
function: 'function',
17-
lineno: 1,
18-
},
13+
exception: {
14+
values: [
1915
{
20-
colno: 2,
21-
filename: 'filename.js',
22-
function: 'function',
23-
lineno: 2,
16+
value: 'PickleRick',
17+
stacktrace: {
18+
frames: [
19+
{
20+
colno: 1,
21+
filename: 'filename.js',
22+
function: 'function',
23+
lineno: 1,
24+
},
25+
{
26+
colno: 2,
27+
filename: 'filename.js',
28+
function: 'function',
29+
lineno: 2,
30+
},
31+
],
32+
},
2433
},
2534
],
2635
},
2736
};
28-
const exceptionEvent = {
37+
const exceptionEvent: Event = {
2938
exception: {
3039
values: [
3140
{
@@ -64,13 +73,14 @@ describe('Dedupe', () => {
6473
const eventA = clone(messageEvent);
6574
const eventB = clone(messageEvent);
6675
eventB.message = 'EvilMorty';
76+
eventB.exception.values[0].value = 'EvilMorty';
6777
expect(_shouldDropEvent(eventA, eventB)).toBe(false);
6878
});
6979

7080
it('should not drop if events have same messages, but different stacktraces', () => {
7181
const eventA = clone(messageEvent);
7282
const eventB = clone(messageEvent);
73-
eventB.stacktrace.frames[0].colno = 1337;
83+
eventB.exception.values[0].stacktrace.frames[0].colno = 1337;
7484
expect(_shouldDropEvent(eventA, eventB)).toBe(false);
7585
});
7686

0 commit comments

Comments
 (0)