fix meta tag precedence, add more tests, move some files and code around

Author: Lms24

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling/init.js renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/init.js

@@ -7,7 +7,7 @@ Sentry.init({
   integrations: [
     Sentry.browserTracingIntegration({
       linkPreviousTrace: 'in-memory',
-      sampleLinkedTracesConsistently: true
+      consistentTraceSampling: true,
     }),
   ],
   tracePropagationTargets: ['someurl.com'],

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling/subject.js renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/subject.js

@@ -4,13 +4,13 @@ const btn2 = document.getElementById('btn2');
 
 btn1.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
-    Sentry.startSpan({name: 'custom root span 1', op: 'custom'}, () => {});
+    Sentry.startSpan({ name: 'custom root span 1', op: 'custom' }, () => {});
   });
 });
 
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
-    Sentry.startSpan({name: 'custom root span 2', op: 'custom'}, async () => {
+    Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
       await fetch('https://someUrl.com');
     });
   });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling/template.html renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/template.html

@@ -5,15 +5,14 @@ import {
   SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE,
   SEMANTIC_LINK_ATTRIBUTE_LINK_TYPE,
 } from '@sentry/core';
-
-import { sentryTest } from '../../../../../utils/fixtures';
+import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   eventAndTraceHeaderRequestParser,
   shouldSkipTracingTest,
   waitForTransactionRequest,
-} from '../../../../../utils/helpers';
+} from '../../../../../../utils/helpers';
 
-sentryTest.describe('When `sampleLinkedTracesConsistently` is `true`', () => {
+sentryTest.describe('When `consistentTraceSampling` is `true`', () => {
   sentryTest('Continues sampling decision from initial pageload', async ({ getLocalTestUrl, page }) => {
     if (shouldSkipTracingTest()) {
       sentryTest.skip();

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling/test.ts renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/default/test.ts

@@ -7,11 +7,11 @@ Sentry.init({
   integrations: [
     Sentry.browserTracingIntegration({
       linkPreviousTrace: 'in-memory',
-      sampleLinkedTracesConsistently: true
+      consistentTraceSampling: true,
     }),
   ],
   tracePropagationTargets: ['someurl.com'],
   tracesSampleRate: 1,
   debug: true,
-  sendClientReports: true
+  sendClientReports: true,
 });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling-meta-negative/init.js renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/init.js

@@ -4,13 +4,13 @@ const btn2 = document.getElementById('btn2');
 
 btn1.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
-    Sentry.startSpan({name: 'custom root span 1', op: 'custom'}, () => {});
+    Sentry.startSpan({ name: 'custom root span 1', op: 'custom' }, () => {});
   });
 });
 
 btn2.addEventListener('click', () => {
   Sentry.startNewTrace(() => {
-    Sentry.startSpan({name: 'custom root span 2', op: 'custom'}, async () => {
+    Sentry.startSpan({ name: 'custom root span 2', op: 'custom' }, async () => {
       await fetch('https://someUrl.com');
     });
   });

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling-meta-negative/subject.js renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/subject.js

@@ -1,20 +1,20 @@
 import { expect } from '@playwright/test';
 import type { ClientReport } from '@sentry/core';
 import { extractTraceparentData, parseBaggageHeader } from '@sentry/core';
-
-import { sentryTest } from '../../../../../utils/fixtures';
+import { sentryTest } from '../../../../../../utils/fixtures';
 import {
   envelopeRequestParser,
   getMultipleSentryEnvelopeRequests,
+  hidePage,
   shouldSkipTracingTest,
   waitForClientReportRequest,
-} from '../../../../../utils/helpers';
+} from '../../../../../../utils/helpers';
 
 const metaTagSampleRand = 0.9;
 const metaTagSampleRate = 0.2;
 const metaTagTraceId = '12345678901234567890123456789012';
 
-sentryTest.describe('When `sampleLinkedTracesConsistently` is `true` and page contains <meta> tags', () => {
+sentryTest.describe('When `consistentTraceSampling` is `true` and page contains <meta> tags', () => {
   sentryTest(
     'Continues negative sampling decision from meta tag across all traces and downstream propagations',
     async ({ getLocalTestUrl, page }) => {
@@ -81,18 +81,7 @@ sentryTest.describe('When `sampleLinkedTracesConsistently` is `true` and page co
       });
 
       await sentryTest.step('Client report', async () => {
-        await page.evaluate(() => {
-          Object.defineProperty(document, 'visibilityState', {
-            configurable: true,
-            get: function () {
-              return 'hidden';
-            },
-          });
-
-          // Dispatch the visibilitychange event to notify listeners
-          document.dispatchEvent(new Event('visibilitychange'));
-        });
-
+        await hidePage(page);
         const clientReport = envelopeRequestParser<ClientReport>(await clientReportPromise);
         expect(clientReport).toEqual({
           timestamp: expect.any(Number),

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling-meta-negative/template.html renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/template.html

@@ -0,0 +1,19 @@
+import * as Sentry from '@sentry/browser';
+
+window.Sentry = Sentry;
+
+Sentry.init({
+  dsn: 'https://public@dsn.ingest.sentry.io/1337',
+  integrations: [
+    Sentry.browserTracingIntegration({
+      linkPreviousTrace: 'session-storage',
+      consistentTraceSampling: true,
+    }),
+  ],
+  tracePropagationTargets: ['someurl.com'],
+  tracesSampler: ({ inheritOrSampleWith }) => {
+    return inheritOrSampleWith(0);
+  },
+  debug: true,
+  sendClientReports: true,
+});

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/previous-trace-links/consistent-sampling-meta-negative/test.ts renamed to dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/linked-traces/consistent-sampling/meta-negative/test.ts

@@ -0,0 +1,15 @@
+<!doctype html>
+<html>
+  <head>
+    <meta charset="utf-8" />
+    <meta name="sentry-trace" content="a2345678901234567890123456789012-1234567890123456-1" />
+    <meta
+      name="baggage"
+      content="sentry-trace_id=a2345678901234567890123456789012,sentry-sample_rate=0.2,sentry-sampled=true,sentry-transaction=my-transaction,sentry-public_key=public,sentry-release=1.0.0,sentry-environment=prod,sentry-sample_rand=0.12"
+    />
+  </head>
+  <body>
+    <h1>Another Page</h1>
+    <a href="./page-2.html">Go To the next page</a>
+  </body>
+</html>