fix: Set transaction on scope in node for request (#2769)

* fix: Set transaction on scope in node for request * ci: Skip build for size check
getsentry · Jul 23, 2020 · 7956bd8 · 7956bd8
1 parent aa60eea
commit 7956bd8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -45,16 +45,14 @@ jobs:
             node_modules
             */*/node_modules
           key: ${{ runner.os }}-${{ hashFiles('**/yarn.lock') }}
-      - run: yarn install
       - uses: actions/download-artifact@v2
         with:
           name: build
           path: ${{ github.workspace }}/packages
       - uses: andresz1/size-limit-action@v1.4.0
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
-          build_script: echo "doing nothing"
-          skip_step: install
+          skip_step: build
 
   job_lint:
     name: Lint

diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts
@@ -407,6 +407,11 @@ export function errorHandler(options?: {
 
     if (shouldHandleError(error)) {
       withScope(_scope => {
+        // For some reason we need to set the transaction on the scope again
+        const transaction = (res as any).__sentry_transaction as Span;
+        if (transaction && _scope.getSpan() === undefined) {
+          _scope.setSpan(transaction);
+        }
         const eventId = captureException(error);
         (res as any).sentry = eventId;
         next(error);