Child tests

Author: timfish

CHANGELOG.md

@@ -4,44 +4,6 @@
 
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
-## 10.20.0
-
-### Important Changes
-
-- **feat(flags): Add Growthbook integration ([#17440](https://github.com/getsentry/sentry-javascript/pull/17440))**
-
-  Adds a new Growthbook integration for feature flag support.
-
-- **feat(solid): Add support for TanStack Router Solid ([#17735](https://github.com/getsentry/sentry-javascript/pull/17735))**
-
-  Adds support for TanStack Router in the Solid SDK, enabling better routing instrumentation for Solid applications.
-
-- **feat(nextjs): Support native debugIds in turbopack ([#17853](https://github.com/getsentry/sentry-javascript/pull/17853))**
-
-  Adds support for native Debug IDs in Turbopack, improving source map resolution and error tracking for Next.js applications using Turbopack. Native Debug ID generation will be enabled automatically for compatible versions.
-
-### Other Changes
-
-- feat(nextjs): Prepare for next 16 bundler default ([#17868](https://github.com/getsentry/sentry-javascript/pull/17868))
-- feat(node): Capture `pino` logger name ([#17930](https://github.com/getsentry/sentry-javascript/pull/17930))
-- fix(browser): Ignore React 19.2+ component render measure entries ([#17905](https://github.com/getsentry/sentry-javascript/pull/17905))
-- fix(nextjs): Fix createRouteManifest with basePath ([#17838](https://github.com/getsentry/sentry-javascript/pull/17838))
-- fix(react): Add `POP` guard for long-running `pageload` spans ([#17867](https://github.com/getsentry/sentry-javascript/pull/17867))
-- fix(tracemetrics): Send boolean for internal replay attribute ([#17908](https://github.com/getsentry/sentry-javascript/pull/17908))
-- ref(core): Add weight tracking logic to browser logs/metrics ([#17901](https://github.com/getsentry/sentry-javascript/pull/17901))
-
-<details>
-  <summary> <strong>Internal Changes</strong> </summary>
-- chore(nextjs): Add Next.js 16 peer dependency ([#17925](https://github.com/getsentry/sentry-javascript/pull/17925))
-- chore(ci): Update Next.js canary testing ([#17939](https://github.com/getsentry/sentry-javascript/pull/17939))
-- chore: Bump size limit ([#17941](https://github.com/getsentry/sentry-javascript/pull/17941))
-- test(nextjs): Add next@16 e2e test ([#17922](https://github.com/getsentry/sentry-javascript/pull/17922))
-- test(nextjs): Update next 15 tests ([#17919](https://github.com/getsentry/sentry-javascript/pull/17919))
-- chore: Add external contributor to CHANGELOG.md ([#17915](https://github.com/getsentry/sentry-javascript/pull/17915))
-- chore: Add external contributor to CHANGELOG.md ([#17928](https://github.com/getsentry/sentry-javascript/pull/17928))
-- chore: Add external contributor to CHANGELOG.md ([#17940](https://github.com/getsentry/sentry-javascript/pull/17940))
-</details>
-
 Work in this release was contributed by @seoyeon9888, @madhuchavva and @thedanchez . Thank you for your contributions!
 
 ## 10.19.0

dev-packages/node-integration-tests/suites/pino/scenario-track.mjs

@@ -17,7 +17,18 @@ Sentry.withIsolationScope(() => {
 setTimeout(() => {
   Sentry.withIsolationScope(() => {
     Sentry.startSpan({ name: 'later' }, () => {
-      logger.error(new Error('oh no'));
+      // This child should be captured as we marked the parent logger to be tracked
+      const child = logger.child({ module: 'authentication' });
+      child.error(new Error('oh no'));
+
+      // This child should be ignored
+      const child2 = logger.child({ module: 'authentication.v2' });
+      Sentry.pinoIntegration.ignoreLogger(child2);
+      child2.error(new Error('oh no v2'));
+
+      // This should also be ignored as the parent is ignored
+      const child3 = child2.child({ module: 'authentication.v3' });
+      child3.error(new Error('oh no v3'));
     });
   });
 }, 1000);

dev-packages/node-integration-tests/suites/pino/scenario.mjs

@@ -4,7 +4,7 @@ import pino from 'pino';
 const logger = pino({ name: 'myapp' });
 
 const ignoredLogger = pino({ name: 'ignored' });
-Sentry.pinoIntegration.untrackLogger(ignoredLogger);
+Sentry.pinoIntegration.ignoreLogger(ignoredLogger);
 
 ignoredLogger.info('this will not be tracked');
 

dev-packages/node-integration-tests/suites/pino/test.ts

@@ -195,6 +195,7 @@ conditionalTest({ min: 20 })('Pino integration', () => {
                   type: 'string',
                   value: '{"more":3,"complex":"nope"}',
                 },
+                msg: { value: 'hello world', type: 'string' },
                 'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },
                 'sentry.sdk.name': { value: 'sentry.javascript.node', type: 'string' },
@@ -208,6 +209,8 @@ conditionalTest({ min: 20 })('Pino integration', () => {
               severity_number: 17,
               attributes: {
                 name: { value: 'myapp', type: 'string' },
+                module: { value: 'authentication', type: 'string' },
+                msg: { value: 'oh no', type: 'string' },
                 'pino.logger.level': { value: 50, type: 'integer' },
                 'sentry.origin': { value: 'auto.logging.pino', type: 'string' },
                 'sentry.release': { value: '1.0', type: 'string' },

packages/angular/README.md

@@ -16,7 +16,7 @@
 
 ## Angular Version Compatibility
 
-This SDK officially supports Angular 14 to 20.
+This SDK officially supports Angular 14 to 19.
 
 If you're using an older Angular version please check the
 [compatibility table in the docs](https://docs.sentry.io/platforms/javascript/guides/angular/#angular-version-compatibility).

packages/node-core/src/integrations/pino.ts

@@ -97,7 +97,7 @@ function stripIgnoredFields(result: PinoResult): PinoResult {
 
 const _pinoIntegration = defineIntegration((userOptions: DeepPartial<PinoOptions> = {}) => {
   const options: PinoOptions = {
-    autoInstrument: userOptions.autoInstrument === false ? userOptions.autoInstrument : DEFAULT_OPTIONS.autoInstrument,
+    autoInstrument: userOptions.autoInstrument !== false,
     error: { ...DEFAULT_OPTIONS.error, ...userOptions.error },
     log: { ...DEFAULT_OPTIONS.log, ...userOptions.log },
   };
@@ -203,14 +203,14 @@ interface PinoIntegrationFunction {
    *
    * @param logger A Pino logger instance.
    */
-  untrackLogger(logger: unknown): void;
+  ignoreLogger(logger: unknown): void;
 }
 
 /**
  * Integration for Pino logging library.
  * Captures Pino logs as Sentry logs and optionally captures some log levels as events.
  *
- * By default, all Pino loggers will be captured. To ignore a specific logger, use `pinoIntegration.untrackLogger(logger)`.
+ * By default, all Pino loggers will be captured. To ignore a specific logger, use `pinoIntegration.ignoreLogger(logger)`.
  *
  * If you disable automatic instrumentation with `autoInstrument: false`, you can mark specific loggers to be tracked with `pinoIntegration.trackLogger(logger)`.
  *
@@ -222,7 +222,7 @@ export const pinoIntegration = Object.assign(_pinoIntegration, {
       (logger as Pino)[SENTRY_TRACK_SYMBOL] = 'track';
     }
   },
-  untrackLogger(logger: unknown): void {
+  ignoreLogger(logger: unknown): void {
     if (logger && typeof logger === 'object' && 'levels' in logger) {
       (logger as Pino)[SENTRY_TRACK_SYMBOL] = 'ignore';
     }