add test

getsentry · Jul 10, 2024 · b787cb7 · b787cb7
1 parent 95700ba
commit b787cb7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/browser/src/sdk.ts b/packages/browser/src/sdk.ts
@@ -86,7 +86,7 @@ function shouldShowBrowserExtensionError(): boolean {
   const isDedicatedExtensionPage =
     !!runtimeId && WINDOW === WINDOW.top && extensionProtocols.some(protocol => href.startsWith(`${protocol}//`));
 
-  // Running in NW.js, which appears like a browser extension but isn't is also fine
+  // Running the SDK in NW.js, which appears like a browser extension but isn't, is also fine
   // see: https://github.com/getsentry/sentry-javascript/issues/12668
   const isNWjs = typeof windowWithMaybeExtension.nw !== 'undefined';
 

diff --git a/packages/browser/test/unit/sdk.test.ts b/packages/browser/test/unit/sdk.test.ts
@@ -142,6 +142,7 @@ describe('init', () => {
     afterEach(() => {
       Object.defineProperty(WINDOW, 'chrome', { value: undefined, writable: true });
       Object.defineProperty(WINDOW, 'browser', { value: undefined, writable: true });
+      Object.defineProperty(WINDOW, 'nw', { value: undefined, writable: true });
     });
 
     it('logs a browser extension error if executed inside a Chrome extension', () => {
@@ -210,6 +211,18 @@ describe('init', () => {
       consoleErrorSpy.mockRestore();
     });
 
+    it("doesn't log a browser extension error if executed inside an NW.js environment", () => {
+      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+
+      Object.defineProperty(WINDOW, 'nw', { value: {} });
+
+      init(options);
+
+      expect(consoleErrorSpy).not.toHaveBeenCalled();
+
+      consoleErrorSpy.mockRestore();
+    });
+
     it("doesn't return a client on initialization error", () => {
       const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});