make measurements undefined

Author: s1gr1d

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/interactions/test.ts

@@ -140,9 +140,7 @@ sentryTest('should capture an INP click event span. @firefox', async ({ browserN
   // Wait for the interaction transaction from the enableInteractions experiment
   await getMultipleSentryEnvelopeRequests<TransactionJSON>(page, 1);
 
-  const spanEnvelopesPromise = getMultipleSentryEnvelopeRequests<
-    SpanJSON & { exclusive_time: number; measurements: Measurements }
-  >(page, 1, {
+  const spanEnvelopesPromise = getMultipleSentryEnvelopeRequests<SpanJSON>(page, 1, {
     envelopeType: 'span',
   });
   // Page hide to trigger INP
@@ -157,6 +155,6 @@ sentryTest('should capture an INP click event span. @firefox', async ({ browserN
   expect(spanEnvelopes[0].op).toBe('ui.interaction.click');
   expect(spanEnvelopes[0].description).toBe('body > button.clicked');
   expect(spanEnvelopes[0].exclusive_time).toBeGreaterThan(0);
-  expect(spanEnvelopes[0].measurements.inp.value).toBeGreaterThan(0);
-  expect(spanEnvelopes[0].measurements.inp.unit).toBe('millisecond');
+  expect(spanEnvelopes[0].measurements?.inp.value).toBeGreaterThan(0);
+  expect(spanEnvelopes[0].measurements?.inp.unit).toBe('millisecond');
 });

packages/core/src/tracing/measurement.ts

@@ -23,7 +23,11 @@ export function setMeasurement(name: string, value: number, unit: MeasurementUni
 /**
  * Convert timed events to measurements.
  */
-export function timedEventsToMeasurements(events: TimedEvent[]): Measurements {
+export function timedEventsToMeasurements(events: TimedEvent[]): Measurements | undefined {
+  if (!events || events.length === 0) {
+    return undefined;
+  }
+
   const measurements: Measurements = {};
   events.forEach(event => {
     const attributes = event.attributes || {};

packages/opentelemetry/src/spanExporter.ts

@@ -143,7 +143,7 @@ function maybeSend(spans: ReadableSpan[]): ReadableSpan[] {
     transactionEvent.spans = spans;
 
     const measurements = timedEventsToMeasurements(span.events);
-    if (Object.keys(measurements).length) {
+    if (measurements && Object.keys(measurements).length) {
       transactionEvent.measurements = measurements;
     }
 

packages/types/src/span.ts

@@ -57,7 +57,7 @@ export interface SpanJSON {
   _metrics_summary?: Record<string, Array<MetricSummary>>;
   profile_id?: string;
   exclusive_time?: number;
-  measurements: Measurements;
+  measurements?: Measurements;
 }
 
 // These are aligned with OpenTelemetry trace flags