Skip to content

Commit f80f0c6

Browse files
committed
small fixes
1 parent 8fc2b96 commit f80f0c6

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

dev-packages/node-overhead-gh-action/index.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ async function run() {
119119
}
120120

121121
const shouldComment =
122-
isNaN(thresholdNumber) || formatter.hasSizeChanges(base, current, thresholdNumber) || nodeOverheadComment;
122+
isNaN(thresholdNumber) || formatter.hasChanges(base, current, thresholdNumber) || nodeOverheadComment;
123123

124124
if (shouldComment) {
125125
const bodyParts = [NODE_OVERHEAD_HEADING];

dev-packages/node-overhead-gh-action/lib/Formatter.mjs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class Formatter {
2828
return [name, base, current, this.formatPercentageChange(base, current)];
2929
}
3030

31-
hasSizeChanges(base, current, threshold = 0) {
31+
hasChanges(base, current, threshold = 0) {
3232
if (!base || !current) {
3333
return true;
3434
}
@@ -52,9 +52,9 @@ export class Formatter {
5252

5353
return [
5454
headers,
55-
this.formatResult('Baseline', base.baseline, current?.baseline),
56-
this.formatResult('With Sentry', base.withInstrument, current?.withInstrument),
57-
this.formatResult('With Sentry (error only)', base.withInstrumentErrorOnly, current?.withInstrumentErrorOnly),
55+
this.formatResult('Baseline', base?.baseline, current?.baseline),
56+
this.formatResult('With Sentry', base?.withInstrument, current?.withInstrument),
57+
this.formatResult('With Sentry (error only)', base?.withInstrumentErrorOnly, current?.withInstrumentErrorOnly),
5858
];
5959
}
6060
}

0 commit comments

Comments
 (0)