Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated JSX transform #11932

Closed
3 tasks done
topaxi opened this issue May 7, 2024 · 3 comments · Fixed by #12204
Closed
3 tasks done

Outdated JSX transform #11932

topaxi opened this issue May 7, 2024 · 3 comments · Fixed by #12204
Labels
Package: remix Issues related to the Sentry Remix SDK Type: Bug

Comments

@topaxi
Copy link
Contributor

topaxi commented May 7, 2024

Is there an existing issue for this?

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/remix

SDK Version

7.113.0

Framework Version

React canary or React 19 Beta

Link to Sentry event

No response

SDK Setup

No response

Steps to Reproduce

Use and install Sentry with React canary or React 19 Beta.

Expected Result

No warning should be logged. Sentry React artifacts should use the new(ish? 😁) JSX transform.

Actual Result

Warning: Your app (or one of its dependencies) is using an outdated JSX transform. Update to the modern JSX transform for faster performance: https://react.dev/link/new-jsx-transform
SentryRoot
div
div
body
html
Layout@http://localhost:4000/app/root.tsx:63:7
RenderedRoute@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:403:7
RenderErrorBoundary@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:360:5
DataRoutes@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:1392:7
Router@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:748:7
RouterProvider@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:1209:7
RemixErrorBoundary@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:3451:5
RemixBrowser@http://localhost:4000/node_modules/.vite/deps/chunk-TGWP4JAX.js?v=55caa5db:4108:46
@github-actions github-actions bot added the Package: remix Issues related to the Sentry Remix SDK label May 7, 2024
@lforst
Copy link
Member

lforst commented May 10, 2024

Thanks for letting us know! We'll make sure that this is not gonna happen when react 19 drops, or at least shortly after :)

@kentcdodds
Copy link

Just bumped into this myself. Was going to contribute until I saw the build comes from @sentry-internal/rollup-utils. So I'll just leave this to you all. Thanks!

@lforst
Copy link
Member

lforst commented May 24, 2024

@kentcdodds Thanks for trying 😂 I am taking a look at this right now. I was wondering how libraries should go about using a jsx runtime so I was looking up how react router does it for example but it seems like you guys are also still using React.createElement.

The concrete problem I am facing is whether to use import { jsx } from 'react/jsx-runtime' or whether to use import { jsxDEV } from 'react/jsx-dev-runtime' in our compiled code. I would assume the former but I am not sure of the impact in dev mode. Actually looking a bit further into it, it seems jsx will just alias to jsxDEV in dev mode 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: remix Issues related to the Sentry Remix SDK Type: Bug
Projects
Archived in project
4 participants