Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable includeLocalVariables by default #13041

Open
AbhiPrasad opened this issue Jul 24, 2024 · 3 comments
Open

Enable includeLocalVariables by default #13041

AbhiPrasad opened this issue Jul 24, 2024 · 3 comments
Labels
Feature: Errors Migrated Package: node Issues related to the Sentry Node SDK

Comments

@AbhiPrasad
Copy link
Member

AbhiPrasad commented Jul 24, 2024 •
edited
Loading

Description

https://sentry.slack.com/archives/CA2V2LBDL/p1721771426857869

We should do one final benchmark before we carry on with this
@AbhiPrasad AbhiPrasad added Feature: Errors Package: node Issues related to the Sentry Node SDK labels Jul 24, 2024
@AbhiPrasad
Copy link
Member Author

For the time being, we can add includeLocalVariable: true to all the onboarding docs until this change is added and released.

@AbhiPrasad AbhiPrasad added this to the 9.0.0 milestone Jul 24, 2024
@Bruno-DaSilva
Copy link

Bruno-DaSilva commented Aug 18, 2024 •
edited
Loading

If I may suggest, take a look at (and hopefully address) #13414 #13415 #13416 and #13417 as there appears to be some buggy behaviour that should likely get solved first, before defaulting this to enabled? Or at least some documentation around eg. that debugging is not possible with this enabled.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Aug 18, 2024
@lforst
Copy link
Member

lforst commented Aug 26, 2024

@Bruno-DaSilva Thanks for the reports. We'll consider those before doing anything in the direction of enabling (or suggesting) by default.

@lforst lforst mentioned this issue Oct 31, 2024
Open
@ale-cota ale-cota mentioned this issue Nov 11, 2024
Open
@lforst lforst removed this from the 9.0.0 milestone Nov 13, 2024
@linear linear bot added the Migrated label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Errors Migrated Package: node Issues related to the Sentry Node SDK
Projects
GitHub Issues with 👀 3
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lforst @Lms24 @Bruno-DaSilva @AbhiPrasad