-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
TrpcMiddleware types are not compatible with trpc v11 #13424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, thanks for filing this. Sentry employees are currently involved in a company-wide hackweek. We will take a look at this issue next week. See #13421. |
Thanks for this input, we are going to implement the new interface. Right now, we offer support for version 10. |
@captain-hak would you mind sharing a reproduction example with the error? I just tried out the Sentry middleware with trpc@11 and I don't get any type errors. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Problem Statement
Hello,
I just implemented trpc v11 in my node project and the only thing that is not working anymore is the types compatibilities between the middleware factory in trpc and the trpcMiddleware handler in sentry.
As stated in this doc from trpc, rawInput in middleware is now a getRawInput.
Is it something that you are aware of?
Are you going to implement the new interface?
Thanks for your help !
Solution Brainstorm
I think the file concerned with this issue is here : https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/trpc.ts#L17
The text was updated successfully, but these errors were encountered: