Skip to content

TrpcMiddleware types are not compatible with trpc v11 #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
captain-hak opened this issue Aug 19, 2024 · 5 comments
Closed

TrpcMiddleware types are not compatible with trpc v11 #13424

captain-hak opened this issue Aug 19, 2024 · 5 comments
Labels

Comments

@captain-hak
Copy link

Problem Statement

Hello,
I just implemented trpc v11 in my node project and the only thing that is not working anymore is the types compatibilities between the middleware factory in trpc and the trpcMiddleware handler in sentry.

As stated in this doc from trpc, rawInput in middleware is now a getRawInput.

Is it something that you are aware of?
Are you going to implement the new interface?

Thanks for your help !

Solution Brainstorm

I think the file concerned with this issue is here : https://github.com/getsentry/sentry-javascript/blob/develop/packages/core/src/trpc.ts#L17

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Aug 19, 2024
@andreiborza
Copy link
Member

Hello, thanks for filing this.

Sentry employees are currently involved in a company-wide hackweek. We will take a look at this issue next week. See #13421.

@s1gr1d
Copy link
Member

s1gr1d commented Aug 26, 2024

Thanks for this input, we are going to implement the new interface. Right now, we offer support for version 10.

@lforst
Copy link
Member

lforst commented Aug 26, 2024

@captain-hak would you mind sharing a reproduction example with the error? I just tried out the Sentry middleware with trpc@11 and I don't get any type errors.

@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 3 Sep 13, 2024
@getsantry
Copy link

getsantry bot commented Oct 5, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 5, 2024
@s1gr1d
Copy link
Member

s1gr1d commented Oct 7, 2024

Should be fixed in this PR: #13831

cc @chargome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

5 participants