Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit more breadcrumbs in @sentry/node #13680

Open
10 tasks
mydea opened this issue Sep 12, 2024 · 2 comments
Open
10 tasks

Emit more breadcrumbs in @sentry/node #13680

mydea opened this issue Sep 12, 2024 · 2 comments
Assignees
Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK

Comments

@mydea
Copy link
Member

mydea commented Sep 12, 2024

Description

We should check all our existing Node instrumentation to see if we can easily emit breadcrumbs as well.

It is important not to tie this to spans, as these have no data when not sampled. Instead, where possible we need to use hooks in instrumentation to create breadcrumbs.

Tasks

@mydea mydea added Meta: Help Wanted Package: node Issues related to the Sentry Node SDK labels Sep 12, 2024
@timfish timfish self-assigned this Sep 24, 2024
@timfish
Copy link
Collaborator

timfish commented Sep 25, 2024

Unfortunately, The only one of these otel instrumentations that has a hook that gives us the ability to add breadcrumbs with sampling disabled is fs which has a createHook!

@timfish
Copy link
Collaborator

timfish commented Sep 25, 2024

It's also worth noting that even where we have the createHook for fs, I don't think the endHook gets called with tracing disabled so we can't breadcrumbs with the correct status depending on the result. We also have requireParentSpan: true so even with tracing enabled, you would not get breadcrumbs unless there's a parent span!

We also have this problem with the undici integration where breadcrumbs are created in the responseHook so they are not created with tracing disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta: Help Wanted Package: node Issues related to the Sentry Node SDK
Projects
None yet
Development

No branches or pull requests

2 participants