Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on dataloader integration #13724

Open
2 tasks
onurtemizkan opened this issue Sep 19, 2024 · 1 comment
Open
2 tasks

Improvements on dataloader integration #13724

onurtemizkan opened this issue Sep 19, 2024 · 1 comment
Assignees

Comments

@onurtemizkan
Copy link
Collaborator

onurtemizkan commented Sep 19, 2024

Problem Statement

Following up: #13664

#13664 introduced basic support for dataloader integration on Sentry Node SDK.

In its current state, the feature set is limited, as there's no hook we can get request / lookup information from the underlying instrumentation @opentelemetry/instrumentation-dataloader.

More info on this: #13664 (comment)

Solution Brainstorm

We can open PRs on https://github.com/open-telemetry/opentelemetry-js-contrib/

@AbhiPrasad
Copy link
Member

I think requestHook would be super useful, but luckily we can rely on beforeSendSpan so it's not high priority.

We should see if we can get the extra operations instrumented, and then also see if we can get additional attributes attached to these spans (that then we can use to enable these spans for our cache module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants