Skip to content

[NESTJS] Please add support to NestJS 11 #15110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samuelexferri opened this issue Jan 21, 2025 · 6 comments
Closed

[NESTJS] Please add support to NestJS 11 #15110

samuelexferri opened this issue Jan 21, 2025 · 6 comments
Assignees
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK

Comments

@samuelexferri
Copy link

Problem Statement

Please add support to NestJS 11

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @sentry/nestjs@8.50.0
npm error Found: @nestjs/common@11.0.3
npm error node_modules/@nestjs/common
npm error   @nestjs/common@"^11.0.3" from the root project
npm error   peer @nestjs/common@"^9.0.0 || ^10.0.0 || ^11.0.0" from @nestjs/cache-manager@3.0.0
npm error   node_modules/@nestjs/cache-manager
npm error     @nestjs/cache-manager@"^3.0.0" from the root project
npm error   14 more (@nestjs/config, @nestjs/core, @nestjs/jwt, ...)
npm error
npm error Could not resolve dependency:
npm error peer @nestjs/common@"^8.0.0 || ^9.0.0 || ^10.0.0" from @sentry/nestjs@8.50.0
npm error node_modules/@sentry/nestjs
npm error   @sentry/nestjs@"^8.50.0" from the root project
npm error
npm error Conflicting peer dependency: @nestjs/common@10.4.15
npm error node_modules/@nestjs/common
npm error   peer @nestjs/common@"^8.0.0 || ^9.0.0 || ^10.0.0" from @sentry/nestjs@8.50.0
npm error   node_modules/@sentry/nestjs
npm error     @sentry/nestjs@"^8.50.0" from the root project

Solution Brainstorm

"peerDependencies": {
   "@nestjs/common": "^8.0.0 || ^9.0.0 || ^10.0.0" || ^11.0.0",
   "@nestjs/core": "^8.0.0 || ^9.0.0 || ^10.0.0" || ^11.0.0"
 },
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 21, 2025
@chargome chargome added the Package: nestjs Issues related to the Sentry Nestjs SDK label Jan 21, 2025
@andreiborza
Copy link
Member

Hi @samuelexferri, thanks for filing this.

We'll definitely want to support this, I added it to our backlog and will discuss with the team.

@chargome chargome self-assigned this Jan 21, 2025
@chargome
Copy link
Member

This depends partly on #13674 as NestJS v11 uses Express v5 out of the box. We might be able to ship a version with limited support for now though

@AbhiPrasad AbhiPrasad marked this as a duplicate of #15228 Jan 30, 2025
@chargome chargome marked this as a duplicate of #15285 Feb 4, 2025
@s1gr1d s1gr1d self-assigned this Feb 5, 2025
@Agreon
Copy link

Agreon commented Feb 6, 2025

People searching for an intermediate solution: Add the following to the end of your package.json to enforce the new version:

 "overrides": {
    "@nestjs/common": "^11.0.8",
    "@nestjs/core": "^11.0.8"
  }

Be aware that this still does not guarantee everything works as expected

@s1gr1d
Copy link
Member

s1gr1d commented Feb 11, 2025

Closing this because the PR to add Nest.js support is merged: #15114

Please keep in mind that the support is limited right now, as certain spans regarding Express 5 are missing. However, as soon as Express 5 is supported by Sentry, everything is going to work as usual.

This will be released with the next version of v9.

@s1gr1d s1gr1d closed this as completed Feb 11, 2025
@thgemanuel
Copy link

I have a question, the issue was solved in the new versions of Sentry 9?

@s1gr1d
Copy link
Member

s1gr1d commented Mar 19, 2025

Yes, it's added in 8.51.0 and 9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: nestjs Issues related to the Sentry Nestjs SDK
Projects
Archived in project
Development

No branches or pull requests

6 participants