Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future of rewriteFrames? #2254

Closed
7rulnik opened this issue Sep 27, 2019 · 3 comments
Closed

Future of rewriteFrames? #2254

7rulnik opened this issue Sep 27, 2019 · 3 comments

Comments

@7rulnik
Copy link

7rulnik commented Sep 27, 2019

SourceMap support was introduced in node@12.11.0. Is rewriteFrames still needed for correct stack-traces?

More details in original PR
@kamilogorek
Copy link
Contributor

Yes, it doesn't change anything for now, as rewriteFrames creates a path that is compatible with default sentry-cli artifacts upload. I'll read what changed in new node versions and see how we can utilize it soon.

@7rulnik
Copy link
Author

7rulnik commented Oct 12, 2019

--source-map-support was introduced in node v12.12. Now it supports stack traces.

https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2019-10-11-version-12120-current-bridgear

@kamilogorek
Copy link
Contributor

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamilogorek @7rulnik