-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix Framework SDK #4894
Comments
Hi. Just wanted say that we'd love to see this SDK and to note that https://github.com/jacob-ebey/remix-sentry seems to have made a good start on it. See in particular, https://github.com/jacob-ebey/remix-sentry/blob/7ec8c84689b1cadb2752e741c152d0981f5d45f0/server/sentry-remix-node.js and the results here: #4946 (comment) |
I took the one in there and added the express tracing on top of it so it picks up that transaction. Then in my root loader I pick up __sentry_transaction off of context and add it to data so I can include it in the sentry-trace meta tag on my page. I've managed to get it so that pageloads are tied to the server transaction and vise versa doing that. The only thing I'm missing I think is a more comprehensive browser integration with the router on the client side. |
After we have the SDK in a good place, let's make sure we dogfood with https://github.com/getsentry/vanguard - I've updated the PR checklist accordingly (and I can take care of this!) |
Can't wait to see it released 🤗 |
Do we think this will be released today? Seems like it is almost at the finish line! |
@schwar6-michael - we are wrapping some stuff up, release will come within the next 1-2 days! |
Amazing, cannot wait! |
|
Hi guys, I wanted to use the @sentry/remix with a remix.run app running on netlify but the SDK is 53 mb and that breaks netlify as it has a 50mb zip file limit. |
In particular it is the
who cause a 48mb bloat. Any reason why they are imported by @sentry/remix ? |
I reckon they should be in |
Update: Thanks to AlexMachin1997 I was able to fix this. If you use netlify, add this to your netlify.toml file:
|
hi folks, Just realizing we didn't respond directly here. this isn't an entirely new problem and just to remix, we created this issue to surface more of our internal discussions and try to track and more comprehensive solution @mwawrusch and @marcus-sa |
Hey folks. The Remix SDK has been considering feature complete for an initial launch! We're still in beta, but the public API should be relatively stable. Want to start using it? It's as simple as creating a new Sentry project, and selecting Remix! From there, follow the docs we have to set up your SDK. I'll be closing this issue, and opening new individual one's to track some of the outstanding items we have left. Some of these include
Thanks a lot to everyone who helped us build this out, we appreciate all the help! We could not have done this without the help of the Remix community. Please reach out if you have any feedback or bugs to report! |
Problem Statement
Support https://remix.run/ JavaScript framework. See: https://github.com/remix-run/remix.
If you are interested in this, please react to this issue and/or leave a comment below!
Solution Brainstorm
A SDK similar to what we have for NextJS.
Uses React + Node SDK under the hood
Work
@sentry/remix
to the release registry feat: Add @sentry/remix SDK sentry-release-registry#77sentry-javascript/packages/remix/package.json
Line 16 in 8a8e489
Stretch Goals (will be converted to separate issues if not tackled by GA)
ErrorBoundary
feat(remix): Wrap root withErrorBoundary
. #5365handleDocumentRequest
functions fix(remix): WraphandleDocumentRequest
functions. #5387meta
tag to propogatesentry-trace
header from server -> client feat(remix): Setsentry-trace
<meta>
on server-side. #5440The text was updated successfully, but these errors were encountered: