fix(core): Remove check and always respect ai.telemetry.functionId for Vercel AI gen spans #17811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_telemetry.functionId for Vercel AI gen spans
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
RulaKhaled
changed the title
RulaKhaled
changed the title
RulaKhaled
changed the title
Lms24
approved these changes
Sep 29, 2025
RulaKhaled
deleted the
rolaabuhasna/js-992-investigate-inconsistent-function-id-in-span-attributes
branch
This was referenced Sep 30, 2025
andreiborza
pushed a commit
to thedanchez/sentry-javascript
that referenced
this pull request
Oct 15, 2025
…r Vercel AI gen spans (getsentry#17811) This PR fixes a mismatch between ai.telemetry.functionId and gen_ai.function_id. Function ids were ignored unless the span name contained exactly one dot. This caused: - gen_ai.function_id to be missing or inconsistent for valid generation spans. - Mismatch between ai.telemetry.functionId and gen_ai.function_id, making trace exploration and metrics harder to interpret. We now always respect experimental_telemetry.functionId when present, where function id could be set as part of request. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Always update Vercel AI generate span names and set `gen_ai.function_id` when `experimental_telemetry.functionId` is present, removing the dot-count check. > > - **Core (Vercel AI span processing)**: > - In `packages/core/src/utils/vercel-ai/index.ts` `processGenerateSpan`: > - Remove `name.split('.')` dot-count check; always apply `experimental_telemetry.functionId`. > - When present, append function ID to the operation name and set `gen_ai.function_id`. > - Clarify comments on telemetry function ID usage. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4b9fa48. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a mismatch between ai.telemetry.functionId and gen_ai.function_id. Function ids were ignored unless the span name contained exactly one dot. This caused:
We now always respect experimental_telemetry.functionId when present, where function id could be set as part of request.
Note
Always update Vercel AI generate span names and set
gen_ai.function_idwhenexperimental_telemetry.functionIdis present, removing the dot-count check.packages/core/src/utils/vercel-ai/index.tsprocessGenerateSpan:name.split('.')dot-count check; always applyexperimental_telemetry.functionId.gen_ai.function_id.Written by Cursor Bugbot for commit 4b9fa48. This will update automatically on new commits. Configure here.