Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentry log channel ignores report method on a handled exception #541

Closed
adiachenko opened this issue Feb 4, 2022 · 1 comment
Closed

Comments

@adiachenko
Copy link

Environment

How do you use Sentry?
Sentry SaaS (sentry.io)

Which SDK and version?
Laravel 8.0 sentry/sentry-laravel:2.11.0

Steps to Reproduce

  1. Configure Sentry in Laravel Log channels by following this guide
  2. Create an exception with a report method that returns false as shown in the snippet below (documented here).
  3. Throw this exception somewhere.
public function report()
{
    return false;
}

Expected Result

Exception is NOT reported to Sentry.

Actual Result

Exception is reported to Sentry. You have to explicitly add an exception to the exception handler's $dontReport array if you want to ignore it.

@cleptric
Copy link
Member

As we hook into Laravel's reporting system, returning false has the desired effect and is not considered a bug imo.

@cleptric cleptric closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants