You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setting the number of breadcrumbs to a number other that the default does not lead to that number being used
When does the problem happen
During build
During run-time
When capturing a hard crash
Environment
OS: [Windows/Mac/Linux]
Compiler: [GCC 10/MSVC 19.16.27030.1]
CMake version and config: [e.g. 3.18.1, SENTRY_BACKEND=inproc]
Steps To Reproduce
During application startup run the line of code
sentry_options_set_max_breadcrumbs(options, 256);
Log more than 256 events, then crash
observe that only 100 (the default) will be logged
Suggested Resolution
It appears that sentry__crashpad_backend_add_breadcrumb uses SENTRY_BREADCRUMBS_MAX without looking to the
value set in options. an alteration such as below may be suitable, though consideration may need to be given to resizing buffers and any aspects of threading that I have not looked into.
Description
Setting the number of breadcrumbs to a number other that the default does not lead to that number being used
When does the problem happen
Environment
Steps To Reproduce
During application startup run the line of code
sentry_options_set_max_breadcrumbs(options, 256);
Log more than 256 events, then crash
observe that only 100 (the default) will be logged
Suggested Resolution
It appears that sentry__crashpad_backend_add_breadcrumb uses SENTRY_BREADCRUMBS_MAX without looking to the
value set in options. an alteration such as below may be suitable, though consideration may need to be given to resizing buffers and any aspects of threading that I have not looked into.
static void
sentry__crashpad_backend_add_breadcrumb(
sentry_backend_t *backend, sentry_value_t breadcrumb)
{
crashpad_state_t *data = (crashpad_state_t *)backend->data;
}
The text was updated successfully, but these errors were encountered: