Merge f326ff2 into 7b6ed9c

Author: antonis

CHANGELOG.md

@@ -6,6 +6,22 @@
 > make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first.
 <!-- prettier-ignore-end -->
 
+## Unreleased
+
+### Features
+
+- Adds `replaysSessionQuality` Session Replay option ([#5001](https://github.com/getsentry/sentry-react-native/pull/5001))
+
+  ```js
+  import * as Sentry from '@sentry/react-native';
+
+  Sentry.init({
+    replaysSessionSampleRate: 1.0,
+    replaysSessionQuality: 'low', // possible values: low, medium (default), high
+    integrations: [Sentry.mobileReplayIntegration()],
+  });
+  ```
+
 ## 6.18.0
 
 ### Fixes

packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift

@@ -48,7 +48,7 @@ final class RNSentryReplayOptions: XCTestCase {
     }
 
     func assertAllDefaultReplayOptionsAreNotNil(replayOptions: [String: Any]) {
-        XCTAssertEqual(replayOptions.count, 8)
+        XCTAssertEqual(replayOptions.count, 9)
         XCTAssertNotNil(replayOptions["sessionSampleRate"])
         XCTAssertNotNil(replayOptions["errorSampleRate"])
         XCTAssertNotNil(replayOptions["maskAllImages"])
@@ -57,6 +57,7 @@ final class RNSentryReplayOptions: XCTestCase {
         XCTAssertNotNil(replayOptions["sdkInfo"])
         XCTAssertNotNil(replayOptions["enableViewRendererV2"])
         XCTAssertNotNil(replayOptions["enableFastViewRendering"])
+        XCTAssertNotNil(replayOptions["quality"])
     }
 
     func testSessionSampleRate() {
@@ -248,5 +249,73 @@ final class RNSentryReplayOptions: XCTestCase {
 
         XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering)
     }
+    
+    func testReplayQualityDefault() {
+        let optionsDict = ([
+            "dsn": "https://abc@def.ingest.sentry.io/1234567",
+            "replaysOnErrorSampleRate": 0.75
+        ] as NSDictionary).mutableCopy() as! NSMutableDictionary
+
+        RNSentryReplay.updateOptions(optionsDict)
+
+        let actualOptions = try! Options(dict: optionsDict as! [String: Any])
+
+        XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
+    }
 
+    func testReplayQualityLow() {
+        let optionsDict = ([
+            "dsn": "https://abc@def.ingest.sentry.io/1234567",
+            "replaysOnErrorSampleRate": 0.75,
+            "replaysSessionQuality": "low"
+        ] as NSDictionary).mutableCopy() as! NSMutableDictionary
+
+        RNSentryReplay.updateOptions(optionsDict)
+
+        let actualOptions = try! Options(dict: optionsDict as! [String: Any])
+
+        XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.low)
+    }
+
+    func testReplayQualityMedium() {
+        let optionsDict = ([
+            "dsn": "https://abc@def.ingest.sentry.io/1234567",
+            "replaysOnErrorSampleRate": 0.75,
+            "replaysSessionQuality": "medium"
+        ] as NSDictionary).mutableCopy() as! NSMutableDictionary
+
+        RNSentryReplay.updateOptions(optionsDict)
+
+        let actualOptions = try! Options(dict: optionsDict as! [String: Any])
+
+        XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
+    }
+
+    func testReplayQualityHigh() {
+        let optionsDict = ([
+            "dsn": "https://abc@def.ingest.sentry.io/1234567",
+            "replaysOnErrorSampleRate": 0.75,
+            "replaysSessionQuality": "high"
+        ] as NSDictionary).mutableCopy() as! NSMutableDictionary
+
+        RNSentryReplay.updateOptions(optionsDict)
+
+        let actualOptions = try! Options(dict: optionsDict as! [String: Any])
+
+        XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.high)
+    }
+
+    func testReplayQualityInvalidFallsBackToMedium() {
+        let optionsDict = ([
+            "dsn": "https://abc@def.ingest.sentry.io/1234567",
+            "replaysOnErrorSampleRate": 0.75,
+            "replaysSessionQuality": "invalid"
+        ] as NSDictionary).mutableCopy() as! NSMutableDictionary
+
+        RNSentryReplay.updateOptions(optionsDict)
+
+        let actualOptions = try! Options(dict: optionsDict as! [String: Any])
+
+        XCTAssertEqual(actualOptions.sessionReplay.quality, SentryReplayOptions.SentryReplayQuality.medium)
+    }
 }

packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java

@@ -45,6 +45,7 @@
 import io.sentry.SentryLevel;
 import io.sentry.SentryOptions;
 import io.sentry.SentryReplayOptions;
+import io.sentry.SentryReplayOptions.SentryReplayQuality;
 import io.sentry.UncaughtExceptionHandlerIntegration;
 import io.sentry.android.core.AndroidLogger;
 import io.sentry.android.core.AndroidProfiler;
@@ -86,6 +87,7 @@
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Properties;
 import java.util.concurrent.CountDownLatch;
@@ -370,6 +372,12 @@ private SentryReplayOptions getReplayOptions(@NotNull ReadableMap rnOptions) {
             ? rnOptions.getDouble("replaysOnErrorSampleRate")
             : null);
 
+    if (rnOptions.hasKey("replaysSessionQuality")) {
+      final String qualityString = rnOptions.getString("replaysSessionQuality");
+      final SentryReplayQuality quality = parseReplayQuality(qualityString);
+      androidReplayOptions.setQuality(quality);
+    }
+
     if (!rnOptions.hasKey("mobileReplayOptions")) {
       return androidReplayOptions;
     }
@@ -398,6 +406,27 @@ private SentryReplayOptions getReplayOptions(@NotNull ReadableMap rnOptions) {
     return androidReplayOptions;
   }
 
+  private SentryReplayQuality parseReplayQuality(@Nullable String qualityString) {
+    if (qualityString == null) {
+      return SentryReplayQuality.MEDIUM;
+    }
+
+    try {
+      switch (qualityString.toLowerCase(Locale.ROOT)) {
+        case "low":
+          return SentryReplayQuality.LOW;
+        case "medium":
+          return SentryReplayQuality.MEDIUM;
+        case "high":
+          return SentryReplayQuality.HIGH;
+        default:
+          return SentryReplayQuality.MEDIUM;
+      }
+    } catch (Exception e) {
+      return SentryReplayQuality.MEDIUM;
+    }
+  }
+
   public void crash() {
     throw new RuntimeException("TEST - Sentry Client Crash (only works in release mode)");
   }

packages/core/ios/RNSentryReplay.mm

@@ -1,5 +1,6 @@
 #import "RNSentryReplay.h"
 #import "RNSentryReplayBreadcrumbConverterHelper.h"
+#import "RNSentryReplayQuality.h"
 #import "RNSentryVersion.h"
 #import "React/RCTTextView.h"
 #import "Replay/RNSentryReplayMask.h"
@@ -22,9 +23,12 @@ + (void)updateOptions:(NSMutableDictionary *)options
     NSLog(@"Setting up session replay");
     NSDictionary *replayOptions = options[@"mobileReplayOptions"] ?: @{};
 
+    NSString *qualityString = options[@"replaysSessionQuality"];
+
     [options setValue:@{
         @"sessionSampleRate" : options[@"replaysSessionSampleRate"] ?: [NSNull null],
         @"errorSampleRate" : options[@"replaysOnErrorSampleRate"] ?: [NSNull null],
+        @"quality" : @([RNSentryReplayQuality parseReplayQuality:qualityString]),
         @"maskAllImages" : replayOptions[@"maskAllImages"] ?: [NSNull null],
         @"maskAllText" : replayOptions[@"maskAllText"] ?: [NSNull null],
         @"enableViewRendererV2" : replayOptions[@"enableViewRendererV2"] ?: [NSNull null],

packages/core/ios/RNSentryReplayQuality.h

@@ -0,0 +1,13 @@
+#import <Foundation/Foundation.h>
+
+NS_ASSUME_NONNULL_BEGIN
+
+typedef NS_ENUM(NSInteger, SentryReplayQuality);
+
+@interface RNSentryReplayQuality : NSObject
+
++ (SentryReplayQuality)parseReplayQuality:(NSString *_Nullable)qualityString;
+
+@end
+
+NS_ASSUME_NONNULL_END

packages/core/ios/RNSentryReplayQuality.m

@@ -0,0 +1,25 @@
+#import "RNSentryReplayQuality.h"
+@import Sentry;
+
+@implementation RNSentryReplayQuality
+
++ (SentryReplayQuality)parseReplayQuality:(NSString *_Nullable)qualityString
+{
+    if (qualityString == nil) {
+        return SentryReplayQualityMedium;
+    }
+
+    NSString *lowercaseQuality = [qualityString lowercaseString];
+
+    if ([lowercaseQuality isEqualToString:@"low"]) {
+        return SentryReplayQualityLow;
+    } else if ([lowercaseQuality isEqualToString:@"medium"]) {
+        return SentryReplayQualityMedium;
+    } else if ([lowercaseQuality isEqualToString:@"high"]) {
+        return SentryReplayQualityHigh;
+    } else {
+        return SentryReplayQualityMedium;
+    }
+}
+
+@end

packages/core/src/js/options.ts

@@ -234,6 +234,14 @@ export interface BaseReactNativeOptions {
    */
   replaysOnErrorSampleRate?: number;
 
+  /**
+   * Defines the quality of the session replay. The higher the quality, the more accurate the replay
+   * will be, but also more data to transfer and more CPU load.
+   *
+   * @default 'medium'
+   */
+  replaysSessionQuality?: SentryReplayQuality;
+
   /**
    * Options which are in beta, or otherwise not guaranteed to be stable.
    */
@@ -275,6 +283,8 @@ export interface BaseReactNativeOptions {
   useThreadsForMessageStack?: boolean;
 }
 
+export type SentryReplayQuality = 'low' | 'medium' | 'high';
+
 export interface ReactNativeTransportOptions extends BrowserTransportOptions {
   /**
    * @deprecated use `maxQueueSize` in the root of the SDK options.

samples/react-native/src/App.tsx

@@ -167,6 +167,7 @@ Sentry.init({
   profilesSampleRate: 1.0,
   replaysSessionSampleRate: 1.0,
   replaysOnErrorSampleRate: 1.0,
+  replaysSessionQuality: 'medium', // default
   spotlight: true,
   // This should be disabled when manually initializing the native SDK
   // Note that options from JS are not passed to the native SDKs when initialized manually