fix(appStart): Handle undefined AppRegistryIntegration.onRunApplication gracefully (#4743)

Author: antonis

packages/core/src/js/tracing/reactnativeprofiler.tsx

@@ -1,4 +1,4 @@
-import { timestampInSeconds } from '@sentry/core';
+import { logger, timestampInSeconds } from '@sentry/core';
 import { getClient, Profiler } from '@sentry/react';
 
 import { getAppRegistryIntegration } from '../integrations/appRegistry';
@@ -49,7 +49,12 @@ export class ReactNativeProfiler extends Profiler {
 
     client.addIntegration && client.addIntegration(createIntegration(this.name));
 
-    getAppRegistryIntegration(client).onRunApplication(ReactNativeProfilerGlobalState.onRunApplicationHook);
+    const appRegistryIntegration = getAppRegistryIntegration(client);
+    if (appRegistryIntegration && typeof appRegistryIntegration.onRunApplication === 'function') {
+      appRegistryIntegration.onRunApplication(ReactNativeProfilerGlobalState.onRunApplicationHook);
+    } else {
+      logger.warn('AppRegistryIntegration.onRunApplication not found or invalid.');
+    }
 
     // eslint-disable-next-line @typescript-eslint/no-floating-promises
     _captureAppStart({ isManual: false });

packages/core/test/wrap.test.tsx

@@ -1,6 +1,11 @@
+import { logger, setCurrentClient } from '@sentry/core';
+import { render } from '@testing-library/react-native';
 import * as React from 'react';
+import { Text } from 'react-native';
 
+import * as AppRegistry from '../src/js/integrations/appRegistry';
 import { wrap } from '../src/js/sdk';
+import { getDefaultTestClientOptions, TestClient } from './mocks/client';
 
 describe('Sentry.wrap', () => {
   it('should not enforce any keys on the wrapped component', () => {
@@ -9,4 +14,23 @@ describe('Sentry.wrap', () => {
 
     expect(typeof ActualWrapped.defaultProps).toBe(typeof Mock.defaultProps);
   });
+
+  it('should wrap the component and init with a warning when getAppRegistryIntegration returns undefined', () => {
+    logger.warn = jest.fn();
+    const getAppRegistryIntegration = jest.spyOn(AppRegistry, 'getAppRegistryIntegration').mockReturnValueOnce(undefined);
+    const Mock: React.FC = () => <Text>Test</Text>;
+    const client = new TestClient(
+      getDefaultTestClientOptions(),
+    );
+    setCurrentClient(client);
+
+    client.init();
+    const ActualWrapped = wrap(Mock);
+
+    const { getByText } = render(<ActualWrapped />);
+
+    expect(getAppRegistryIntegration).toHaveBeenCalled();
+    expect(logger.warn).toHaveBeenCalledWith('AppRegistryIntegration.onRunApplication not found or invalid.');
+    expect(getByText('Test')).toBeTruthy();
+  });
 });