Error bundle release android

[lorenzoangelini]

Environment

I'm using the last version of react native,"react-native": "0.64.0", and last version of sentry "@sentry/react-native": "^2.3.0"

Steps to Reproduce

I run bundleStagingRelease or assembleStagingRelease

Expected Result

The bundle is created correctly

Actual Result

Task :app:bundleStagingReleaseJsAndAssets_SentryUpload_-1898184413 FAILED
Task :app:bundleStagingReleaseJsAndAssets_SentryUpload_-1898184415 FAILED
error: Found argument '-1' which wasn't expected, or isn't valid in this context
USAGE:
sentry-cli react-native gradle [OPTIONS] --bundle --dist ... --release --sourcemap

[jennmueng]

Closing this in favor of #1401

[zoontek]

@jennmueng I don't think this is the same issue. This one happen because a - is prepend here: SentryUpload_-1898184413 (Found argument '-1')

In my case, it fails with:

Task :app:bundleDevelopmentReleaseJsAndAssets_SentryUpload_-868184591 FAILED
error: Found argument '-8' which wasn't expected, or isn't valid in this context

[zoontek]

I got it, this is related to this change in RN 0.64:

output.versionCodeOverride =
-   versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
+   defaultConfig.versionCode * 1000 + versionCodes.get(abi)

As this change is only "for new apps", it should be reverted. More infos here: facebook/react-native#29808

[jennmueng]

@zoontek Hmm, as we just wrap the original build task:

sentry-react-native/sentry.gradle

Line 69 in 5fbd5ba

def nameCliTask = "${bundleTask.name}_SentryUpload_${versionCode}"

and take the original version code as is, then that means the original version code override is invalid in the first place right? I'm not too familiar with gradle myself.

[marandaneto]

@jennmueng do you know if we should do something about it?

[github-actions]

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

[marandaneto]

sounds like its been fixed on RN itself facebook/react-native#29808
closing it then -> https://github.com/facebook/react-native/blob/main/template/android/app/build.gradle#L179-L180