Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps not parsed correctly, using 5.4.2 with sentry-expo #3064

Closed
6 of 11 tasks
jongbelegen opened this issue May 12, 2023 · 3 comments
Closed
6 of 11 tasks

Sourcemaps not parsed correctly, using 5.4.2 with sentry-expo #3064

jongbelegen opened this issue May 12, 2023 · 3 comments

Comments

@jongbelegen
Copy link

jongbelegen commented May 12, 2023

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native (>= 1.0.0)
  • react-native-sentry (<= 0.43.2)

SDK version: 5.4.2

react-native version: 0.71.7

Are you using Expo?

  • Yes (With eas build, so not the premade runtime)
  • No

Are you using sentry.io or on-premise?

  • sentry.io (SaaS)
  • on-premise

If you are using sentry.io, please post a link to your issue so we can take a look:
ios: https://fastlane-festivals.sentry.io/issues/4177600521/?project=4505164525535232&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
android: https://fastlane-festivals.sentry.io/issues/4177474793/?project=4505164525535232&query=is%3Aunresolved&referrer=issue-stream&stream_index=3

Configuration:

(@sentry/react-native)

Sentry.init({
  dsn: "https://7299b45869854e44be478ad0fdfe6c43@o1366760.ingest.sentry.io/4505164525535232",
  enableInExpoDevelopment: true,
});

I have the following issue:
Sourcemaps are not parsed correctly.
Firstly I spoke with @krystofwoldrich about a problem relating to an older use of sentry-react-native.
As discussed I created a reproducible demo of a minimal setup using sentry-expo using a newer version of sentry-react-native. You can see the steps that I took to create this demo on the repo.
It also consists of builds and source maps.

I also made the expo config compatible with the new sentry version. You can see those changes here

This consisted of the following for ios:

  • Use debug-files instead of upload-dsym
  • Add /scripts/collect-modules.sh to the build phase

It would be awesome if we could make a version of sentry-expo with the latest version of Sentry that does not have the mono repo issues from the currently used version + all the new goodies you guys have been working on.

I'll do my best to get this merged upstream to sentry-expo as soon as we have figured out how to make everything work.

Thanks in advance!

@krystofwoldrich
Copy link
Member

Hi,
thank you for following up on the comment from sentry-expo, I'll try out the sample and let you know what have I found.

Also the upgrade to @sentry/react-native@5 in sentry-expo looks good and we will be happy to help to make it work and get merged.

@krystofwoldrich krystofwoldrich self-assigned this May 12, 2023
@krystofwoldrich
Copy link
Member

krystofwoldrich commented May 26, 2023

Hi,
following up on the sample app. Thank you for the detailed guide.

I've successfully built the iOS app and got a correctly symbolicated stack trace as you did, plus Sentry UI doesn't show any error.

I will test the Android soon.

Update:
The same happened for the Android app. The stack trace is symbolicated and doesn't show any errors.
https://krystofs-org.sentry.io/share/issue/5ef20a7f762b4a5b91f61b9e948e2f33/

We made some changes to our backend services in the past weeks. @jongbelegen Could you try your sample app again, it looks like source maps are working.

@krystofwoldrich
Copy link
Member

I'm closing this for now, because I wasn't able to reproduce the issue. If there will be any new information/ideas we can reopen the issue.

Please look at the upgrade PR expo/sentry-expo#337

@krystofwoldrich krystofwoldrich closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants