-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.18.0 fails to build with jsbundle not found #3583
Comments
Hi @proohit, Can you add |
sorry for the delay. here are the logs:
I should also mention that the app is managed in a monorepo setup. The app is at the following location: Also note that I changed actual names and altered the logs for that matter. |
and for reference, this is the build logs without sentry:
|
@proohit Thank you for the long, we will look thought them and keep you posted. |
Seems like the latest @sentry/wizard (3.20.4) modifies PBXShellScriptBuildPhase shellScript in a wrong way. Version 3.20.3 makes it in the right way. set -e
export NODE_ARGS="--max-old-space-size=8192"
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT \"\"/bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode.sh $REACT_NATIVE_XCODE\"\"" after 3.20.3 install: set -e
export NODE_ARGS="--max-old-space-size=8192"
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT \"\"\"/bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode.sh $REACT_NATIVE_XCODE\"\"\"" |
Hi, Can you enable source maps without Sentry, to verify if that is the case? set -e
+ export SOURCEMAP_FILE="$DERIVED_FILE_DIR/main.jsbundle.map"
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT \"$REACT_NATIVE_XCODE\"" |
Hi @tarasfo, There should be only one wrapping Like this: set -e
export NODE_ARGS="--max-old-space-size=8192"
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT \"/bin/sh ../node_modules/@sentry/react-native/scripts/sentry-xcode.sh $REACT_NATIVE_XCODE\"" |
@krystofwoldrich here is how it looked:
|
@tarasfo When you manually fix the script does the source maps upload work as expected? I've checked the wizard and we test this patch here https://github.com/getsentry/sentry-wizard/blob/921384095e8da0829588d88713ba125ee36a88c2/test/react-native/xcode.test.ts#L54 |
@tarasfo I haven't manually fix the script, I just reinstalled sentry with |
@krystofwoldrich yes, will try that tomorrow. By the way, we did not use the wizard to set up sentry but did it manually. We had sentry already installed and needed to migrate to a higher version. |
@krystofwoldrich here are the logs with generated source maps:
Also note: After some experimenting, everything (including source maps and debug ids) works with this script: export SENTRY_PROPERTIES=sentry.properties
export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export PROJECT_ROOT=".."
set -e
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT \"../node_modules/@sentry/cli/bin/sentry-cli react-native xcode $REACT_NATIVE_XCODE\""
/bin/sh ../node_modules/@sentry/react-native/scripts/collect-modules.sh But this uses the "old" sentry cli instead of the "new" sentry react native script |
@proohit Thank you for the message, I also see that in your working script, you added At this point I'm not able to determine why it's failing, I'm happy to hear that the legacy approach works for you. Would you be able to reproduce this in a clean project that you can share with us so we can debug it? |
I am having the same issue, but only with one of the schemes in my XCode project. 2 of the schemes build successfully, 1 of them fail with the same error. Android builds fine for all 3 schemes.
|
@mikeshuttjuvo Thank you for the message, can you share the names of the schemes, is it Debug and Release? Can you share a large part of the failed log? |
I believe my issue was related to this one: facebook/react-native#41844. I had schemes with spaces in the name (i.e., "MyApp Testing", "MyApp Staging") which was causing bundler issues. I was experimenting with different fixes for that which were in turn causing the error I reported above. I ended up just renaming my schemes to remove the spaces and everything was resolved. |
@mikeshuttjuvo Thank you for the message, I'm happy to hear it works for you now. |
I'm closing this issue since the last few messages mention the build is working. If you are reading this and have a similar error, please open a new issue with details about your project. |
OS:
Platform:
SDK:
@sentry/react-native
(>= 1.0.0)react-native-sentry
(<= 0.43.2)SDK version: 5.18.0
Are you using Expo?
Are you using sentry.io or on-premise?
Configuration:
(
@sentry/react-native
)I have the following issue:
Updating from 5.5.0 to 5.18.0. We wanted to have auto debug ids and source map upload, which we didn't have up to now. However, the integration of Sentry in the
Bundle React Native code and images
build phase fails. This is the build phase script:The scripts fails with the following error:
There seems to be something off with the way Sentry executes the react native xcode script. Note that the build succeeds if
BUNDLE_REACT_NATIVE
is changed to ignore Sentry:That way the bundle is being generated, but no sourcemaps in the above mentioned path. Yes, we could add
SOURCEMAP_FILE
so that react native generates sourcemaps, but we would have to upload and match source maps manually to sentry.Using react native 0.71.7
Actual result:
Expected the app to build successfully and Sentry uploading source maps to sentry.io
NOTE: Android works without any problems. App builds and uploads source maps/debug id via gradle.
The text was updated successfully, but these errors were encountered: