-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using expo-datadog
and @sentry/react-native/expo
in Expo results in missing bundle file
#3941
Comments
Hey @lepskiy thanks for reporting, we'll take a look. Note that due to conference and PTOs we might be a bit slower to respond than usual. Also, can you confirm that this is the same issue as you reported in #3551 (comment)? |
Please also refer to our migration guide from |
Confirm, this is a duplicate. I've just decided to create a new ticket instead of the comment in the closed one. |
Hi @lepskiy, The message
The log you shared is from a Debug build. Sentry doesn't look for a source maps in debug builds as no bundles are generated. The Sentry log from above:
|
Had the same EAS build error with both Alternatively, when either one of the config plugins is excluded, the app builds and runs successfully. Tested with Crash report indicates an uncaught exception throwing RCTFatal in |
Completely the same. After moving DataDog below Sentry the build is fixed but the build is crashed on iOS (on Android works fine).
|
Hi @lepskiy and @jhbarnett, The conclusion is using |
Would you be able to provide a reproducible example? |
Small note, I see that the shared Could you regenerate the native projects or update the build phase manually to use |
expo-datadog
and @sentry/react-native/expo
in Expo results in missing bundle file
How to use
Both When both plugins are used the build phase results in valid bash script, but the executed commands will fail to produce the JS Bundle. ✅ Recommendation 1: Use only one of the plugins. If you are using only of the SDKs to capture errors, use its plugin. The other SDK if not used for errors doesn't need the auto debug files upload. ✅ Recommendation 2: Use none of the plugins and upload the debug files manually. To see how to generate and upload source maps you can follow this guide https://docs.sentry.io/platforms/react-native/sourcemaps/uploading/expo-advanced/#manual-upload-for-hermes-release
|
Remarks: Execution order export SOURCEMAP_FILE=$DERIVED_FILE_DIR/main.jsbundle.map
if [[ -z "$DATADOG_CI_EXEC" ]]; then
DATADOG_CI_EXEC="$("$NODE_BINARY" --print "require('path').resolve(require('path').dirname(require.resolve('@datadog/datadog-ci/package.json')), '../../.bin/datadog-ci')")";
# Check if the file exists and is executable
if [[ -x "$DATADOG_CI_EXEC" ]]; then
export DATADOG_CI_EXEC;
else
echo "Error: DATADOG_CI_EXEC does not exist or is not executable";
exit 1;
fi
fi
/bin/sh `"$NODE_BINARY" --print "require('path').dirname(require.resolve('@sentry/react-native/package.json')) + '/scripts/sentry-xcode.sh'"` $DATADOG_CI_EXEC react-native xcode `"$NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'"` The issue is Execution order /bin/sh `"$NODE_BINARY" --print "require('path').dirname(require.resolve('@sentry/react-native/package.json')) + '/scripts/sentry-xcode.sh'"` `"$NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'"`
if [[ -z "$DATADOG_CI_EXEC" ]]; then
DATADOG_CI_EXEC="$("$NODE_BINARY" --print "require('path').resolve(require('path').dirname(require.resolve('@datadog/datadog-ci/package.json')), '../../.bin/datadog-ci')")";
# Check if the file exists and is executable
if [[ -x "$DATADOG_CI_EXEC" ]]; then
export DATADOG_CI_EXEC;
else
echo "Error: DATADOG_CI_EXEC does not exist or is not executable";
exit 1;
fi
fi
$DATADOG_CI_EXEC react-native xcode `"$NODE_BINARY" --print "require('path').dirname(require.resolve('react-native/package.json')) + '/scripts/react-native-xcode.sh'"` In this case |
OS:
Platform:
SDK:
@sentry/react-native
(>= 1.0.0)react-native-sentry
(<= 0.43.2)SDK version: 5.20.0
react-native
version: 0.73.6Are you using Expo?
Are you using sentry.io or on-premise?
Configuration:
(
@sentry/react-native
)I have the following issue:
After upgrading to Expo 50 and migrating from sentry-expo to @sentry/react-native the build (using remote EAS Build) started failing.
Steps to reproduce:
Actual result:
EAS build is failed with the error:
XCode logs:
Expected result:
Build finish succesfully.
The text was updated successfully, but these errors were encountered: