-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onunhandledrejection
error machanism type to rejected promises
#4093
Labels
Comments
We create a new event in the global error handler and we set the error mechanism, there is no previous value.
sentry-react-native/packages/core/src/js/integrations/reactnativeerrorhandlers.ts Lines 81 to 85 in 933804e
And I agree we should add the correct mechanism to it. |
krystofwoldrich
changed the title
Preserve original error mechanism from sentry-javascript
Add Sep 30, 2024
onunhandledrejection
error machanism type to rejected promises
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently we override whatever mechanism comes from the JS sdk, see here:
sentry-react-native/src/js/integrations/reactnativeerrorhandlers.ts
Lines 146 to 160 in c2a4e9b
Perhaps we should preserve the original mechanism type at least, because it might be useful when filtering issues in issue stream/discover. One such case was reported with regards to
onunhandledrejection
type for unhandled promise rejections.The text was updated successfully, but these errors were encountered: