Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bumps sample app to RN 0.76.2 #4207

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

chore(deps): Bumps sample app to RN 0.76.2 #4207

wants to merge 26 commits into from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 25, 2024 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps sample app to RN 0.76.2

Refs:

💡 Motivation and Context

RN 0.76.0 release

Fix #4188

💚 How did you test it?

Manual Testing with the sample apps, CI
Verify that the Android app does not crash with profiling enabled

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.31 ms 1218.64 ms 1.33 ms
Size 2.36 MiB 3.10 MiB 753.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fe13591+dirty 1208.25 ms 1219.53 ms 11.28 ms
d2c32bb+dirty 1223.69 ms 1229.49 ms 5.80 ms
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
ad6c299+dirty 1244.76 ms 1260.10 ms 15.34 ms
eb1e19f+dirty 1209.56 ms 1214.94 ms 5.38 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
1faf8e3+dirty 1214.87 ms 1222.83 ms 7.97 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
4cc5c27+dirty 1211.45 ms 1214.60 ms 3.16 ms

App size

Revision Plain With Sentry Diff
fe13591+dirty 2.36 MiB 3.10 MiB 752.40 KiB
d2c32bb+dirty 2.36 MiB 3.08 MiB 737.22 KiB
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
ad6c299+dirty 2.36 MiB 2.84 MiB 488.85 KiB
eb1e19f+dirty 2.36 MiB 3.08 MiB 737.21 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
1faf8e3+dirty 2.36 MiB 3.08 MiB 736.75 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
4cc5c27+dirty 2.36 MiB 3.04 MiB 698.52 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
be4394d+dirty 1228.31 ms 1228.27 ms -0.04 ms
e6a2b88+dirty 1221.27 ms 1222.12 ms 0.86 ms

App size

Revision Plain With Sentry Diff
be4394d+dirty 2.36 MiB 3.10 MiB 752.34 KiB
e6a2b88+dirty 2.36 MiB 3.08 MiB 735.59 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.98 ms 439.29 ms 43.31 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
63ed251+dirty 485.02 ms 531.16 ms 46.14 ms
ac41368+dirty 395.91 ms 451.17 ms 55.26 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
4a6664f+dirty 357.02 ms 394.91 ms 37.89 ms
9cd0e9f+dirty 383.65 ms 418.65 ms 35.00 ms
e1ea4a8+dirty 451.98 ms 497.58 ms 45.60 ms
b1e8712+dirty 322.55 ms 331.84 ms 9.29 ms

App size

Revision Plain With Sentry Diff
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
63ed251+dirty 7.15 MiB 8.35 MiB 1.20 MiB
ac41368+dirty 7.15 MiB 8.39 MiB 1.24 MiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
4a6664f+dirty 7.15 MiB 8.22 MiB 1.07 MiB
9cd0e9f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e1ea4a8+dirty 7.15 MiB 8.35 MiB 1.20 MiB
b1e8712+dirty 7.15 MiB 8.04 MiB 912.27 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
be4394d+dirty 269.00 ms 322.83 ms 53.83 ms
e6a2b88+dirty 402.42 ms 470.18 ms 67.76 ms

App size

Revision Plain With Sentry Diff
be4394d+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e6a2b88+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.31 ms 1240.88 ms -6.43 ms
Size 2.92 MiB 3.66 MiB 758.62 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fe13591+dirty 1250.69 ms 1246.27 ms -4.43 ms
d2c32bb+dirty 1244.00 ms 1245.77 ms 1.77 ms
c2a4e9b+dirty 1247.39 ms 1243.04 ms -4.35 ms
ad6c299+dirty 1248.50 ms 1248.88 ms 0.38 ms
eb1e19f+dirty 1229.91 ms 1231.63 ms 1.71 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
1faf8e3+dirty 1223.38 ms 1220.56 ms -2.82 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
52a8031+dirty 1255.96 ms 1273.00 ms 17.04 ms
4cc5c27+dirty 1220.43 ms 1215.13 ms -5.30 ms

App size

Revision Plain With Sentry Diff
fe13591+dirty 2.92 MiB 3.66 MiB 757.71 KiB
d2c32bb+dirty 2.92 MiB 3.64 MiB 742.84 KiB
c2a4e9b+dirty 2.92 MiB 3.64 MiB 739.91 KiB
ad6c299+dirty 2.92 MiB 3.40 MiB 494.12 KiB
eb1e19f+dirty 2.92 MiB 3.64 MiB 742.82 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
1faf8e3+dirty 2.92 MiB 3.64 MiB 742.61 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
52a8031+dirty 2.92 MiB 3.38 MiB 475.71 KiB
4cc5c27+dirty 2.92 MiB 3.61 MiB 705.47 KiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
be4394d+dirty 1230.27 ms 1226.51 ms -3.76 ms
e6a2b88+dirty 1252.67 ms 1252.24 ms -0.43 ms

App size

Revision Plain With Sentry Diff
be4394d+dirty 2.92 MiB 3.66 MiB 756.68 KiB
e6a2b88+dirty 2.92 MiB 3.64 MiB 741.24 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 440.08 ms 443.42 ms 3.34 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e2b64fe 316.88 ms 330.23 ms 13.35 ms
5446992 403.40 ms 426.70 ms 23.30 ms
eb1e19f 433.55 ms 444.90 ms 11.35 ms
cdf2f33 469.46 ms 462.17 ms -7.29 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
80b2ce3 385.02 ms 387.36 ms 2.34 ms
8ae23a7 526.83 ms 513.38 ms -13.45 ms
2ec71da 438.14 ms 460.46 ms 22.32 ms
d361d38 354.10 ms 381.69 ms 27.59 ms

App size

Revision Plain With Sentry Diff
e2b64fe 17.73 MiB 19.80 MiB 2.07 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB
eb1e19f 17.74 MiB 20.08 MiB 2.34 MiB
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
80b2ce3 17.73 MiB 19.75 MiB 2.02 MiB
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
2ec71da 17.73 MiB 20.10 MiB 2.37 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB

Previous results on branch: antonis/chore-samples-rn0.76.0

Startup times

Revision Plain With Sentry Diff
be4394d 420.09 ms 416.15 ms -3.95 ms
e6a2b88 648.02 ms 633.98 ms -14.04 ms

App size

Revision Plain With Sentry Diff
be4394d 17.74 MiB 20.08 MiB 2.34 MiB
e6a2b88 17.74 MiB 20.08 MiB 2.34 MiB

@antonis antonis changed the title chore(deps): Bumps sample app to RN 0.76.0 chore(deps): Bumps sample app to RN 0.76.1 Oct 30, 2024
@krystofwoldrich
Copy link
Member

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist

It this still an issue?

@antonis
Copy link
Collaborator Author

antonis commented Nov 7, 2024

(NOBRIDGE) ERROR ReferenceError: An error was thrown when attempting to render log messages via LogBox.
Property 'setImmediate' doesn't exist
It this still an issue?

@krystofwoldrich yes. The iOS sample compiles successfully and the error occurs on load preventing the app from loading. I guess this is some dependency issue but I haven't figured out a solution yet. Any suggestions are welcome 🙇

@antonis antonis changed the title chore(deps): Bumps sample app to RN 0.76.1 chore(deps): Bumps sample app to RN 0.76.2 Nov 18, 2024
@antonis antonis marked this pull request as ready for review November 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Sample Application New Architecture Crash with RN 0.75 when profiling is enabled
2 participants
@antonis @krystofwoldrich