Stub stackprof for rack as well, since results is unreliable

Author: sl0thentr0py

sentry-ruby/lib/sentry/profiler.rb

@@ -25,7 +25,7 @@ class StackProfProfiler < NoopProfiler
     DEFAULT_INTERVAL = 1e6 / 101
     MICRO_TO_NANO_SECONDS = 1e3
 
-    attr_reader :sampled, :started, :event_id
+    attr_reader :sampled, :started, :event_id, :results
 
     def initialize(configuration)
       @event_id = SecureRandom.uuid.delete('-')
@@ -96,6 +96,7 @@ def to_hash
       return {} unless @started
 
       results = StackProf.results
+      @results = results
       return {} unless results
       return {} if results.empty?
       return {} if results[:samples] == 0

sentry-ruby/lib/sentry/transaction_event.rb

@@ -20,6 +20,8 @@ class TransactionEvent < Event
     # @return [Hash, nil]
     attr_accessor :profile
 
+    attr_reader :profiler
+
     def initialize(transaction:, **options)
       super(**options)
 
@@ -36,6 +38,7 @@ def initialize(transaction:, **options)
       finished_spans = transaction.span_recorder.spans.select { |span| span.timestamp && span != transaction }
       self.spans = finished_spans.map(&:to_hash)
 
+      @profiler = transaction.profiler
       populate_profile(transaction)
     end
 

sentry-ruby/spec/sentry/rack/capture_exceptions_spec.rb

@@ -2,13 +2,6 @@
 
 require 'spec_helper'
 
-module TestApp
-  def self.foo
-    sleep 0.1
-    "ok"
-  end
-end
-
 RSpec.describe Sentry::Rack::CaptureExceptions, rack: true do
   let(:exception) { ZeroDivisionError.new("divided by 0") }
   let(:additional_headers) { {} }
@@ -658,16 +651,28 @@ def will_be_sampled_by_sdk
         end
       end
 
+      let(:stackprof_results) do
+        data = StackProf::Report.from_file('spec/support/stackprof_results.json').data
+        # relative dir differs on each machine
+        data[:frames].each { |_id, fra| fra[:file].gsub!(/<dir>/, Dir.pwd) }
+        data
+      end
+
+      before do
+        allow(StackProf).to receive(:results).and_return(stackprof_results)
+      end
+
       it "collects a profile" do
         app = ->(_) do
-          [200, {}, [TestApp.foo]]
+          [200, {}, "ok"]
         end
 
         stack = described_class.new(app)
         stack.call(env)
         event = last_sentry_event
 
         profile = event.profile
+        puts(event.profiler.inspect)
         expect(profile).not_to be_nil
 
         expect(profile[:event_id]).not_to be_nil