Migrate from to_hash to to_h (#2351)

* Migrate from to_hash to to_h

As @solnic pointed out in #2350 (comment)
`to_hash` has special meaning in Ruby and could be called implicitly
in contexts like double splatting argument. So we should switch to `to_h`
to avoid potential issues.

Author: st0012

CHANGELOG.md

@@ -3,6 +3,7 @@
 ### Breaking Changes
 
 - Remove `config.async` [#1894](https://github.com/getsentry/sentry-ruby/pull/1894)
+- Migrate from to_hash to to_h ([#2351](https://github.com/getsentry/sentry-ruby/pull/2351))
 
 ## Unreleased
 

sentry-delayed_job/spec/sentry/delayed_job_spec.rb

@@ -46,7 +46,7 @@ def do_nothing_with_args(a)
     enqueued_job.invoke_job
 
     expect(transport.events.count).to eq(1)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:message]).to eq("report")
     expect(event[:contexts][:"Delayed-Job"][:id]).to eq(enqueued_job.id.to_s)
     expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
@@ -68,7 +68,7 @@ def do_nothing_with_args(a)
     enqueued_job.invoke_job
 
     expect(transport.events.count).to eq(1)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:message]).to eq("tagged report")
     expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil, number: 1 })
 
@@ -77,7 +77,7 @@ def do_nothing_with_args(a)
     enqueued_job.invoke_job
 
     expect(transport.events.count).to eq(2)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
   end
 
@@ -93,7 +93,7 @@ def do_nothing_with_args(a)
       end.to raise_error(ZeroDivisionError)
 
       expect(transport.events.count).to eq(1)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
 
       expect(event[:sdk]).to eq({ name: "sentry.ruby.delayed_job", version: described_class::VERSION })
       expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -109,7 +109,7 @@ def do_nothing_with_args(a)
       end.to raise_error(RuntimeError)
 
       expect(transport.events.count).to eq(1)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
 
       expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil, number: 1 })
       expect(Sentry.get_current_scope.extra).to eq({})
@@ -123,7 +123,7 @@ def do_nothing_with_args(a)
       end.to raise_error(ZeroDivisionError)
 
       expect(transport.events.count).to eq(2)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
       expect(event[:tags]).to eq({ "delayed_job.id" => enqueued_job.id.to_s, "delayed_job.queue" => nil })
       expect(Sentry.get_current_scope.extra).to eq({})
       expect(Sentry.get_current_scope.tags).to eq({})
@@ -228,7 +228,7 @@ def perform
       it "injects ActiveJob information to the event" do
         expect(transport.events.count).to eq(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
         expect(event[:message]).to eq("report from ActiveJob")
         expect(event[:tags]).to match({ "delayed_job.id" => anything, "delayed_job.queue" => "default", number: 1 })
         expect(event[:contexts][:"Active-Job"][:job_class]).to eq("ReportingJob")
@@ -255,7 +255,7 @@ def perform
       it "injects ActiveJob information to the event" do
         expect(transport.events.count).to eq(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
         expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
         expect(event[:tags]).to match({ "delayed_job.id" => anything, "delayed_job.queue" => "default", number: 2 })
         expect(event[:contexts][:"Active-Job"][:job_class]).to eq("FailedJob")

sentry-rails/spec/sentry/rails/activejob_spec.rb

@@ -254,7 +254,7 @@ def perform
         expect(transport.events.size).to eq(1)
 
         event = transport.events.first
-        exceptions_data = event.exception.to_hash[:values]
+        exceptions_data = event.exception.to_h[:values]
 
         expect(exceptions_data.count).to eq(2)
         expect(exceptions_data[0][:type]).to eq("FailedJob::TestError")
@@ -293,7 +293,7 @@ def perform
         first = transport.events[0]
         check_in_id = first.check_in_id
         expect(first).to be_a(Sentry::CheckInEvent)
-        expect(first.to_hash).to include(
+        expect(first.to_h).to include(
           type: 'check_in',
           check_in_id: check_in_id,
           monitor_slug: "normaljobwithcron",
@@ -302,7 +302,7 @@ def perform
 
         second = transport.events[1]
         expect(second).to be_a(Sentry::CheckInEvent)
-        expect(second.to_hash).to include(
+        expect(second.to_h).to include(
           :duration,
           type: 'check_in',
           check_in_id: check_in_id,
@@ -321,7 +321,7 @@ def perform
         first = transport.events[0]
         check_in_id = first.check_in_id
         expect(first).to be_a(Sentry::CheckInEvent)
-        expect(first.to_hash).to include(
+        expect(first.to_h).to include(
           type: 'check_in',
           check_in_id: check_in_id,
           monitor_slug: "failed_job",
@@ -331,7 +331,7 @@ def perform
 
         second = transport.events[1]
         expect(second).to be_a(Sentry::CheckInEvent)
-        expect(second.to_hash).to include(
+        expect(second.to_h).to include(
           :duration,
           type: 'check_in',
           check_in_id: check_in_id,

sentry-rails/spec/sentry/rails/breadcrumbs/active_support_logger_spec.rb

@@ -130,7 +130,7 @@
 
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.last.to_hash
+      transaction = transport.events.last.to_h
       breadcrumbs = transaction[:breadcrumbs][:values]
       process_action_crumb = breadcrumbs.last
       expect(process_action_crumb[:category]).to eq("process_action.action_controller")

sentry-rails/spec/sentry/rails/breadcrumbs/monotonic_active_support_logger_spec.rb

@@ -134,7 +134,7 @@
 
         expect(transport.events.count).to eq(1)
 
-        transaction = transport.events.last.to_hash
+        transaction = transport.events.last.to_h
         breadcrumbs = transaction[:breadcrumbs][:values]
         process_action_crumb = breadcrumbs.last
         expect(process_action_crumb[:category]).to eq("process_action.action_controller")

sentry-rails/spec/sentry/rails/controller_methods_spec.rb

@@ -37,7 +37,7 @@ def request
       event = transport.events.last
       expect(event.message).to eq("foo")
       expect(event.tags).to eq({ new_tag: true })
-      expect(event.to_hash.dig(:request, :url)).to eq("http://example.org/test")
+      expect(event.to_h.dig(:request, :url)).to eq("http://example.org/test")
     end
   end
 
@@ -49,8 +49,8 @@ def request
 
       event = transport.events.last
       expect(event.tags).to eq({ new_tag: true })
-      expect(event.to_hash.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
-      expect(event.to_hash.dig(:request, :url)).to eq("http://example.org/test")
+      expect(event.to_h.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
+      expect(event.to_h.dig(:request, :url)).to eq("http://example.org/test")
     end
   end
 end

sentry-rails/spec/sentry/rails/event_spec.rb

@@ -8,7 +8,7 @@
   end
 
   it "sets right SDK information" do
-    event_hash = Sentry::Rails.capture_message("foo").to_hash
+    event_hash = Sentry::Rails.capture_message("foo").to_h
 
     expect(event_hash[:sdk]).to eq(name: "sentry.ruby.rails", version: Sentry::Rails::VERSION)
   end
@@ -27,7 +27,7 @@
       e
     end
 
-    let(:hash) { Sentry::Rails.capture_exception(exception).to_hash }
+    let(:hash) { Sentry::Rails.capture_exception(exception).to_h }
 
     it 'marks in_app correctly' do
       frames = hash[:exception][:values][0][:stacktrace][:frames]

sentry-rails/spec/sentry/rails/tracing/action_controller_subscriber_spec.rb

@@ -32,7 +32,7 @@
 
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.first.to_hash
+      transaction = transport.events.first.to_h
       expect(transaction[:type]).to eq("transaction")
       expect(transaction[:spans].count).to eq(2)
 

sentry-rails/spec/sentry/rails/tracing/action_view_subscriber_spec.rb

@@ -20,7 +20,7 @@
 
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.first.to_hash
+      transaction = transport.events.first.to_h
       expect(transaction[:type]).to eq("transaction")
       expect(transaction[:spans].count).to eq(2)
 

sentry-rails/spec/sentry/rails/tracing/active_record_subscriber_spec.rb

@@ -30,7 +30,7 @@
 
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.first.to_hash
+      transaction = transport.events.first.to_h
       expect(transaction[:type]).to eq("transaction")
       expect(transaction[:spans].count).to eq(1)
 
@@ -67,7 +67,7 @@ def foo
         it "doesn't record query's source location" do
           expect(transport.events.count).to eq(1)
 
-          transaction = transport.events.first.to_hash
+          transaction = transport.events.first.to_h
           expect(transaction[:type]).to eq("transaction")
           expect(transaction[:spans].count).to eq(1)
 
@@ -86,7 +86,7 @@ def foo
         it "records query's source location" do
           expect(transport.events.count).to eq(1)
 
-          transaction = transport.events.first.to_hash
+          transaction = transport.events.first.to_h
           expect(transaction[:type]).to eq("transaction")
           expect(transaction[:spans].count).to eq(1)
 
@@ -104,7 +104,7 @@ def foo
         it "doesn't record query's source location" do
           expect(transport.events.count).to eq(1)
 
-          transaction = transport.events.first.to_hash
+          transaction = transport.events.first.to_h
           expect(transaction[:type]).to eq("transaction")
           expect(transaction[:spans].count).to eq(1)
 
@@ -131,7 +131,7 @@ def foo
 
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.first.to_hash
+      transaction = transport.events.first.to_h
       expect(transaction[:type]).to eq("transaction")
       expect(transaction[:spans].count).to eq(2)
 

sentry-rails/spec/sentry/rails/tracing/active_storage_subscriber_spec.rb

@@ -25,7 +25,7 @@
       expect(response).to have_http_status(:ok)
       expect(transport.events.count).to eq(2)
 
-      analysis_transaction = transport.events.first.to_hash
+      analysis_transaction = transport.events.first.to_h
       expect(analysis_transaction[:type]).to eq("transaction")
 
       if Rails.version.to_f > 6.1
@@ -40,7 +40,7 @@
         expect(analysis_transaction[:spans][0][:origin]).to eq("auto.file.rails")
       end
 
-      request_transaction = transport.events.last.to_hash
+      request_transaction = transport.events.last.to_h
       expect(request_transaction[:type]).to eq("transaction")
       expect(request_transaction[:spans].count).to eq(2)
 

sentry-rails/spec/sentry/rails/tracing_spec.rb

@@ -26,8 +26,8 @@
       expect(response).to have_http_status(:internal_server_error)
       expect(transport.events.count).to eq(2)
 
-      event = transport.events.first.to_hash
-      transaction = transport.events.last.to_hash
+      event = transport.events.first.to_h
+      transaction = transport.events.last.to_h
 
       expect(event.dig(:contexts, :trace, :trace_id).length).to eq(32)
       expect(event.dig(:contexts, :trace, :trace_id)).to eq(transaction.dig(:contexts, :trace, :trace_id))
@@ -64,7 +64,7 @@
       expect(response).to have_http_status(:ok)
       expect(transport.events.count).to eq(1)
 
-      transaction = transport.events.last.to_hash
+      transaction = transport.events.last.to_h
 
       expect(transaction[:type]).to eq("transaction")
       expect(transaction.dig(:contexts, :trace, :op)).to eq("http.server")
@@ -254,7 +254,7 @@
 
       expect(transport.events.count).to eq(3)
 
-      transaction = transport.events.last.to_hash
+      transaction = transport.events.last.to_h
 
       expect(transaction[:type]).to eq("transaction")
       expect(transaction[:transaction]).to eq("PostsController#show")

sentry-resque/spec/sentry/resque_spec.rb

@@ -66,7 +66,7 @@ def self.perform(msg)
     process_job(worker)
 
     expect(transport.events.count).to eq(1)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:message]).to eq("report")
     expect(event[:tags]).to eq({ "resque.queue" => "default" })
     expect(event[:contexts][:"Resque"]).to include({ job_class: "MessageJob", arguments: ["report"], queue: "default" })
@@ -88,7 +88,7 @@ def self.perform(msg)
     process_job(worker)
 
     expect(transport.events.count).to eq(1)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:message]).to eq("tagged report")
     expect(event[:tags]).to include({ number: 1 })
 
@@ -97,7 +97,7 @@ def self.perform(msg)
     process_job(worker)
 
     expect(transport.events.count).to eq(2)
-    event = transport.events.last.to_hash
+    event = transport.events.last.to_h
     expect(event[:tags]).to eq({ "resque.queue" => "default" })
   end
 
@@ -109,7 +109,7 @@ def self.perform(msg)
       end.to change { Resque::Stat.get("failed") }.by(1)
 
       expect(transport.events.count).to eq(1)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
 
       expect(event[:sdk]).to eq({ name: "sentry.ruby.resque", version: described_class::VERSION })
       expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -123,7 +123,7 @@ def self.perform(msg)
       end.to change { Resque::Stat.get("failed") }.by(1)
 
       expect(transport.events.count).to eq(1)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
 
       expect(event[:tags]).to eq({ "resque.queue" => "default", number: 1 })
       expect(Sentry.get_current_scope.extra).to eq({})
@@ -135,7 +135,7 @@ def self.perform(msg)
       end.to change { Resque::Stat.get("failed") }.by(1)
 
       expect(transport.events.count).to eq(2)
-      event = transport.events.last.to_hash
+      event = transport.events.last.to_h
       expect(event[:tags]).to eq({ "resque.queue" => "default" })
       expect(Sentry.get_current_scope.extra).to eq({})
       expect(Sentry.get_current_scope.tags).to eq({})
@@ -161,7 +161,7 @@ def self.perform(msg)
           end
         end.to change { transport.events.count }.by(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
 
         expect(event[:sdk]).to eq({ name: "sentry.ruby.resque", version: described_class::VERSION })
         expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -175,7 +175,7 @@ def self.perform(msg)
         end.to change { Resque::Stat.get("failed") }.by(1)
            .and change { transport.events.count }.by(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
 
         expect(event[:sdk]).to eq({ name: "sentry.ruby.resque", version: described_class::VERSION })
         expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -201,7 +201,7 @@ def self.perform(msg)
           end
         end.to change { transport.events.count }.by(3)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
 
         expect(event[:sdk]).to eq({ name: "sentry.ruby.resque", version: described_class::VERSION })
         expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
@@ -266,7 +266,7 @@ def perform
       it "injects ActiveJob information to the event" do
         expect(transport.events.count).to eq(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
         expect(event[:message]).to eq("report from ActiveJob")
         expect(event[:tags]).to match({ "resque.queue" => "default", number: 1 })
         expect(event[:contexts][:"Active-Job"][:job_class]).to eq("AJMessageJob")
@@ -291,7 +291,7 @@ def perform
       it "injects ActiveJob information to the event" do
         expect(transport.events.count).to eq(1)
 
-        event = transport.events.last.to_hash
+        event = transport.events.last.to_h
         expect(event.dig(:exception, :values, 0, :type)).to eq("ZeroDivisionError")
         expect(event[:tags]).to match({ "resque.queue" => "default", number: 2 })
         expect(event[:contexts][:"Active-Job"][:job_class]).to eq("AJFailedJob")