stack level too deep (SystemStackError) after upgrading from 4.6.1 to 4.6.2

[knapo]

Describe the bug
Per 4dc603b#commitcomment-54080150

4.6.2 extends Rake::Task with aliasing execute method. Unfortunately this causes stack level too deep (SystemStackError), when Rake::Task#execute is overridden using #prepend

To Reproduce

Create a Rakefile:

require 'bundler/inline'
require 'rake'

module MyGem
  module Task
    def execute(...)
      # do something
      super(...)
    end
  end
end

Rake::Task.prepend(MyGem::Task)

require 'sentry-ruby'

task(:test) { }

Run rake test

Expected behavior

rake test should not cause SystemStackError

Actual behavior

rake test ends with SystemStackError

Environment

• Ruby Version: 3.0.2

[xiazek]

👍 Similar problem on my project.

[st0012]

Thanks for raising the issue to also let other users add reaction to it 👍

I just checked a few similar gems that have rake integration. These are prepend-only ones:

• Datadog
• Appsignal

newrelic-ruby-agent supports both method aliasing and prepend, but since 7.0 the default would be prepend.

And scout_apm, which uses method aliasing for patching classes (see #1427 for more detail), doesn't have rake integration.

So I think it's relatively safe to move from method aliasing to prepend 🙂

[st0012]

@knapo thanks again for the reporting and PR. I've released 4.6.4, which contains the fix 🙂

[knapo]

Great, thx a lot too!