Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API methods used in the migration guide do not appear in RDoc #1657

Closed
geeksam opened this issue Dec 27, 2021 · 2 comments · Fixed by #1677
Closed

API methods used in the migration guide do not appear in RDoc #1657

geeksam opened this issue Dec 27, 2021 · 2 comments · Fixed by #1677
Assignees
Milestone

Comments

@geeksam
Copy link

geeksam commented Dec 27, 2021

Issue Description

I wanted to update Faraday on an older application, but the sentry-raven dependency was preventing it. YAK SHAVING, HERE WE COME!

Reproduction Steps

  • In the application's Gemfile, replace sentry-raven with sentry-rails and sentry-ruby and run bundle
  • Get a failure message about the Gemfile.lock being locked to an older version of Faraday
  • Run bundle update faraday
  • Update config/initializers/sentry.rb
  • Grep the project for references to Raven
    • .capture_exception is easy enough...
    • Raven.user_context doesn't seem to have an equivalent. Consult migration guide, see mention of Sentry.set_user method instead
    • Download the RDoc for both sentry-ruby and sentry-rails into, e.g., Dash
    • Search for set_user in the RDoc for both sentry-rails and sentry-ruby

Expected Behavior

Documentation that describes the shape of data that MUST/SHOULD/MAY (see RFC 2119) be passed to the Sentry.set_user method.

Actual Behavior

The Sentry.set_user method does not appear in the docs at all.

Ruby Version

all

SDK Version

4.8.1

Integration and Its Version

No response

Sentry Config

No response

@st0012
Copy link
Collaborator

st0012 commented Dec 31, 2021

@geeksam hey sorry for the missing docs. I'm adding them recently and they should go out with the v4.9.0 release.

@st0012 st0012 added this to the 4.9.0 milestone Dec 31, 2021
@geeksam
Copy link
Author

geeksam commented Jan 6, 2022

Thanks so much! (Sorry for the delay in replying; way too much email over the weekend.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants