You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Setup Sentry with sidekiq.report_after_job_retries set to true
Create a Sidekiq worker which does not specify the per-worker retry option
Expected Result
According to Sidekiq documentation, if the retry is not specified, jobs will be retried 25 times. So if a job fails 25 times we expect sentry to report only the last one.
Actual Result
Senty reports every failed retry, ignoring the sidekiq.report_after_job_retries option.
However, setting retry option explicitly solves the issue.
Sidekiq's default retry value is true (boolean), while this code expects integer (sentry-sidekiq/lib/sentry/sidekiq/error_handler.rb)
Environment
Sentry SaaS (sentry.io)
Sentry-sidekiq 5.0
Sidekiq 6.4.0
Steps to Reproduce
sidekiq.report_after_job_retries
set totrue
retry
optionExpected Result
According to Sidekiq documentation, if the
retry
is not specified, jobs will be retried 25 times. So if a job fails 25 times we expect sentry to report only the last one.Actual Result
Senty reports every failed retry, ignoring the
sidekiq.report_after_job_retries
option.However, setting retry option explicitly solves the issue.
Sidekiq's default retry value is
true
(boolean), while this code expects integer (sentry-sidekiq/lib/sentry/sidekiq/error_handler.rb)The text was updated successfully, but these errors were encountered: