Skip to content

Span nesting for controller action incorrect #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sl0thentr0py opened this issue Sep 15, 2022 · 0 comments · Fixed by #1973
Closed

Span nesting for controller action incorrect #1899

sl0thentr0py opened this issue Sep 15, 2022 · 0 comments · Fixed by #1973
Assignees

Comments

@sl0thentr0py
Copy link
Member

The span nesting is still not 100% correct since the db spans here should be under the controller.
This is because we just subscribe to the rails notifier signals and only get them once stuff finishes and the current span is not updated as code executes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants