We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rake::Task#execute
I'm a bit confused about this piece of code:
sentry-ruby/sentry-ruby/lib/sentry/rake.rb
Lines 21 to 28 in f15f58e
The override doesn't seem to do much other than call Sentry.get_current_hub.
Sentry.get_current_hub
If this is the case, it would be slightly clearer, in my humble opinion, to define it as:
def execute(args=nil) Sentry.get_current_hub if Sentry.initialized? super end
Did I understand the purpose of the method correctly?
The text was updated successfully, but these errors were encountered:
I think this is leftover code from #1617, I don't even think we need the Task patch anymore. @st0012 can you verify?
Task
Sorry, something went wrong.
@sl0thentr0py Yes you're right. I've opened #2214 to remove it. @hosamaly Thanks for raising this!
sl0thentr0py
Successfully merging a pull request may close this issue.
I'm a bit confused about this piece of code:
sentry-ruby/sentry-ruby/lib/sentry/rake.rb
Lines 21 to 28 in f15f58e
The override doesn't seem to do much other than call
Sentry.get_current_hub
.If this is the case, it would be slightly clearer, in my humble opinion, to define it as:
Did I understand the purpose of the method correctly?
The text was updated successfully, but these errors were encountered: