-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentry::Cron::MonitorCheckIns breaks ActiveJob keyword arguments #2198
Comments
uhh sorry, should have written a better spec, I thought I tested this. |
No probs, many thanks for the quick fix! |
Sorry, has something gone wonky with getsentry-bot? I see it committed release: 5.15.1 yesterday, but the latest release is still showing as 5.15.0. |
@jamesbebbington just released |
Oh I see, it needed a manual merge. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Description
It appears that
Sentry::Cron::MonitorCheckIns::Patch#perform
is not forwarding keyword arguments.Reproduction Steps
include
Sentry::Cron::MonitorCheckIns
in an ActiveJob, and attempt to use keyword arguments.Expected Behavior
Given a job that doesn't include
Sentry::Cron::MonitorCheckIns
:it behaves as expected:
Actual Behavior
Given a job that includes
Sentry::Cron::MonitorCheckIns
:Passing a keyword argument raises an
ArgumentError
:Ruby Version
3.2.2
SDK Version
5.15.0
Integration and Its Version
Rails 7.1.2, GoodJob 3.21.5
Sentry Config
No response
The text was updated successfully, but these errors were encountered: