Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError in session_flusher.rb #2468

Closed
avdi opened this issue Nov 20, 2024 · 1 comment · Fixed by #2469
Closed

NoMethodError in session_flusher.rb #2468

avdi opened this issue Nov 20, 2024 · 1 comment · Fixed by #2469
Assignees

Comments

@avdi
Copy link

avdi commented Nov 20, 2024

Issue Description

This exception from sentry-ruby popped up on Sentry:

Image

Reproduction Steps

We've only seen it happen once, so not sure how to reproduce.

Expected Behavior

Not an exception

Actual Behavior

An exception

Ruby Version

3.2.4

SDK Version

5.21.0

Integration and Its Version

Rails

Sentry Config

No response

@sl0thentr0py
Copy link
Member

sl0thentr0py commented Nov 21, 2024

I'm at a loss how this could happen, this is the relevant code

return unless Session::AGGREGATE_STATUSES.include?(session.status)
@pending_aggregates[session.aggregation_key] ||= init_aggregates(session.aggregation_key)
@pending_aggregates[session.aggregation_key][session.status] += 1

EDIT: nvm, I think we need a lock, will add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants