Add debug symbol uploads for Win32 and MacOS Mono builds (#2021)

Author: TheCrossBoy

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+### Fixes
+
+- Then targeting desktop platforms, the SDK now also uploads debugging symbols when native support is disabled. ([#2021](https://github.com/getsentry/sentry-unity/pull/2021))
+- The SDK will now upload debugging symobol files for macOS mono builds.([#2021](https://github.com/getsentry/sentry-unity/pull/2021))
+
 ### Dependencies
 
 - Bump CLI from v2.41.1 to v2.42.1 ([#2026](https://github.com/getsentry/sentry-unity/pull/2026))

src/Sentry.Unity.Editor/Native/BuildPostProcess.cs

@@ -29,6 +29,9 @@ public static void OnPostProcessBuild(BuildTarget target, string executablePath)
         var isMono = PlayerSettings.GetScriptingBackend(targetGroup) == ScriptingImplementation.Mono2x;
 #pragma warning restore CS0618
 
+        var buildOutputDir = Path.GetDirectoryName(executablePath);
+        var executableName = Path.GetFileName(executablePath);
+
         try
         {
             if (options is null)
@@ -52,16 +55,17 @@ public static void OnPostProcessBuild(BuildTarget target, string executablePath)
 
             logger.LogDebug("Adding native support.");
 
-            var buildOutputDir = Path.GetDirectoryName(executablePath);
-            var executableName = Path.GetFileName(executablePath);
             AddCrashHandler(logger, target, buildOutputDir, executableName);
-            UploadDebugSymbols(logger, target, buildOutputDir, executableName, options, cliOptions, isMono);
         }
         catch (Exception e)
         {
             logger.LogError(e, "Failed to add the Sentry native integration to the built application");
             throw new BuildFailedException("Sentry Native BuildPostProcess failed");
         }
+        finally
+        {
+            UploadDebugSymbols(logger, target, buildOutputDir, executableName, options, cliOptions, isMono);
+        }
     }
 
     private static bool IsEnabledForPlatform(BuildTarget target, SentryUnityOptions options) => target switch
@@ -143,6 +147,7 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar
 
         switch (target)
         {
+            case BuildTarget.StandaloneWindows:
             case BuildTarget.StandaloneWindows64:
                 addPath("UnityPlayer.dll");
                 addPath(Path.GetFileNameWithoutExtension(executableName) + "_Data/Plugins/x86_64/sentry.dll");
@@ -192,7 +197,17 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar
                 addPath(Path.GetFullPath($"Packages/{SentryPackageInfo.GetName()}/Plugins/macOS/Sentry/Sentry.dylib.dSYM"));
 
                 if (isMono)
-                { }
+                { 
+                    addFilesMatching(buildOutputDir, new[] { "*.pdb" });
+
+                    // Unity stores the .pdb files in './Library/ScriptAssemblies/' and starting with 2020 in
+                    // './Temp/ManagedSymbols/'. We want the one in 'Temp/ManagedSymbols/' specifically.
+                    var managedSymbolsDirectory = $"{projectDir}/Temp/ManagedSymbols";
+                    if (Directory.Exists(managedSymbolsDirectory))
+                    {
+                        addFilesMatching(managedSymbolsDirectory, new[] { "*.pdb" });
+                    }
+                }
                 else // IL2CPP
                 {
                     addPath(Path.GetFileNameWithoutExtension(executableName) + "_BackUpThisFolder_ButDontShipItWithYourGame");