GPU crashes not captured by Sentry plugin

[riot-pmaconi]

Environment

How do you use Sentry?
Sentry SaaS

Which version of the SDK?

0.18.0

How did you install the package? (Git-URL, Assetstore)

Git

Which version of Unreal?

5.4.4

Is this happening in Unreal (editor) or on a player like Android, iOS, Windows?

Windows client

Steps to Reproduce

1. See a GPU crash that hits ReportGPUCrash (WindowsPlatformCrashContext.cpp:1852) - my case was launching a ton of clients simultaneously, but it could be specific to my project.

Expected Result

The Sentry plugin processes the crash and forwards it to Sentry

Actual Result

The Unreal Crash Reporter processes the crash

Any logs or screenshots

[tustanivsky]

@riot-pmaconi Thank you for bringing this up - we'll check it on our end and get back to you.

Also, this could be related to #381.

[tustanivsky]

This can be reproduced with a debug command: gpudebugcrash [hang|pagefault|platformbreak [compute]]

[tustanivsky]

@riot-pmaconi After investigating this further it appears that the problem may be related to inconsistencies in how the engine handles GPU and non-GPU crashes.

Starting with UE 5.2 it’s possible to disable the default Windows SEH-based crash handling mechanism (https://github.com/EpicGames/UnrealEngine/pull/7976, https://github.com/EpicGames/UnrealEngine/pull/9931) and rely solely on Sentry's crashpad integration. By default, we’re calling FPlatformMisc::SetCrashHandlingType(ECrashHandlingType::Disabled) during the plugin initialization as it's expected that Unreal will select a proper crash handler (Crash Reporter or third-party like ours) based on a provided type value.

However there’s no corresponding check in ReportGPUCrash so the Crash Reporter always has a priority and takes things over. With the following change here I’ve managed to capture GPU crash with the native integration:

__except (FPlatformMisc::GetCrashHandlingType() == ECrashHandlingType::Default ? ReportCrash(GetExceptionInformation()) : EXCEPTION_CONTINUE_SEARCH)
{
	FPlatformMisc::RequestExit(false, TEXT("WindowsPlatformCrashContext.ReportGPUCrash"));
}

Can you try this out on your end and confirm whether it fixes the issue?

[riot-pmaconi]

Thanks for tracking that down. I'll take a look and get back to you.

Are you planning on submitting a PR to Epic to integrate that change directly?

[bitsandfoxes]

If it proves to work out, it might be worth fixing that upstream.

[tustanivsky]

The GPU crash capturing issue should be addressed with this PR - https://github.com/EpicGames/UnrealEngine/pull/12648