-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-native adds wrap during setup #280
Comments
Effort: Small We don't have to cover all cases, let's regex the default RN Template case. |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This got stale but, we should prioritize this and get it done. |
We should focus on automatically wrapping
https://docs.sentry.io/platforms/react-native/manual-setup/expo/#wrap-your-app When the wizard can't find a component to wrap, for example, because the app is using React Native Navigation, we should show a code snippet so the user can wrap the correct component manually. |
The wizard for react native already adds init instrumentation but it could also add the wrap around the
App
removing one more manual step for golden path users, and making the RN wizard a lil more magical 🧙 🪄export default Sentry.wrap(App);
once this is done, we can remove the changes made in the product onboarding, and from the related docs.
getsentry/sentry#85935
The text was updated successfully, but these errors were encountered: