Skip to content

Commit

Permalink
ref(db): Drop project_id from Environment (model state) (#45094)
Browse files Browse the repository at this point in the history
  • Loading branch information
evanpurkhiser authored Feb 28, 2023
1 parent 04032e8 commit 6aaa964
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 3 deletions.
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ To resolve this, rebase against latest master and regenerate your migration. Thi
will then be regenerated, and you should be able to merge without conflicts.

nodestore: 0002_nodestore_no_dictfield
sentry: 0363_debug_id_artifact_bundle
sentry: 0364_remove_project_id_from_environment
social_auth: 0001_initial
35 changes: 35 additions & 0 deletions src/sentry/migrations/0364_remove_project_id_from_environment.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# Generated by Django 2.2.28 on 2023-02-24 20:34

from django.db import migrations

from sentry.new_migrations.migrations import CheckedMigration


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production. For
# the most part, this should only be used for operations where it's safe to run the migration
# after your code has deployed. So this should not be used for most operations that alter the
# schema of a table.
# Here are some things that make sense to mark as dangerous:
# - Large data migrations. Typically we want these to be run manually by ops so that they can
# be monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# have ops run this and not block the deploy. Note that while adding an index is a schema
# change, it's completely safe to run the operation after the code has deployed.
is_dangerous = False

dependencies = [
("sentry", "0363_debug_id_artifact_bundle"),
]

operations = [
migrations.SeparateDatabaseAndState(
database_operations=[],
state_operations=[
migrations.RemoveField(
model_name="environment",
name="project_id",
),
],
),
]
2 changes: 0 additions & 2 deletions src/sentry/models/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ class Environment(Model):

organization_id = BoundedBigIntegerField()
projects = models.ManyToManyField("sentry.Project", through=EnvironmentProject)
# DEPRECATED, use projects
project_id = BoundedBigIntegerField(null=True)
name = models.CharField(max_length=64)
date_added = models.DateTimeField(default=timezone.now)

Expand Down

0 comments on commit 6aaa964

Please sign in to comment.