Skip to content

Commit 931c58d

Browse files
authored
fix(onboarding): Remove sourceMapUploadOptions from Astro (#99371)
related to this change in docs: getsentry/sentry-docs#14905
1 parent 3b500c2 commit 931c58d

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

static/app/gettingStartedDocs/javascript/astro.spec.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ describe('javascript-astro onboarding docs', () => {
174174
).not.toBeInTheDocument();
175175
});
176176

177-
it('shows only sourceMapsUploadOptions in astro.config.mjs', () => {
177+
it('shows only build-time options in astro.config.mjs', () => {
178178
renderWithOnboardingLayout(docs, {
179179
selectedProducts: [
180180
ProductSolution.ERROR_MONITORING,
@@ -184,9 +184,9 @@ describe('javascript-astro onboarding docs', () => {
184184
],
185185
});
186186

187-
// astro.config.mjs should only contain sourceMapsUploadOptions
187+
// astro.config.mjs should only contain build-time options
188188
expect(
189-
screen.getByText(textWithMarkupMatcher(/sourceMapsUploadOptions/))
189+
screen.getByText(textWithMarkupMatcher(/process.env.SENTRY_AUTH_TOKEN/))
190190
).toBeInTheDocument();
191191

192192
// Runtime config should NOT be in astro.config.mjs anymore

static/app/gettingStartedDocs/javascript/astro.tsx

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,9 @@ import sentry from "@sentry/astro";
3939
export default defineConfig({
4040
integrations: [
4141
sentry({
42-
sourceMapsUploadOptions: {
43-
project: "${params.project.slug}",
44-
org: "${params.organization.slug}",
45-
authToken: process.env.SENTRY_AUTH_TOKEN,
46-
},
42+
project: "${params.project.slug}",
43+
org: "${params.organization.slug}",
44+
authToken: process.env.SENTRY_AUTH_TOKEN,
4745
}),
4846
],
4947
});
@@ -407,11 +405,9 @@ import sentry from "@sentry/astro";
407405
export default defineConfig({
408406
integrations: [
409407
sentry({
410-
sourceMapsUploadOptions: {
411-
project: "${params.project.slug}",
412-
org: "${params.organization.slug}",
413-
authToken: process.env.SENTRY_AUTH_TOKEN,
414-
},
408+
project: "${params.project.slug}",
409+
org: "${params.organization.slug}",
410+
authToken: process.env.SENTRY_AUTH_TOKEN,
415411
}),
416412
],
417413
});

0 commit comments

Comments
 (0)