Skip to content

Commit e02427b

Browse files
Abdkhan14Abdullah Khan
andauthored
feat(trace-eap-waterfall): Standalone spans detail panel loads indefnitely (#92879)
- Stand alone spans don't have `transaction_id`s. There `isPending` is always true. - Using isLoading instead and only rendering the transaction specific sections if the data exists. <img width="1242" alt="Screenshot 2025-06-04 at 3 43 27 PM" src="https://github.com/user-attachments/assets/98846735-7b71-486b-80be-dccdf8f8f1ef" /> Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>
1 parent 4b05afe commit e02427b

File tree

1 file changed

+4
-4
lines changed
  • static/app/views/performance/newTraceDetails/traceDrawer/details/span

1 file changed

+4
-4
lines changed

static/app/views/performance/newTraceDetails/traceDrawer/details/span/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ function EAPSpanNodeDetails({
376376

377377
const {
378378
data: eventTransaction,
379-
isPending: isEventTransactionPending,
379+
isLoading: isEventTransactionLoading,
380380
isError: isEventTransactionError,
381381
} = useTransaction({
382382
event_id: node.value.transaction_id,
@@ -388,7 +388,7 @@ function EAPSpanNodeDetails({
388388

389389
const traceState = useTraceState();
390390

391-
if (isTraceItemPending || isEventTransactionPending) {
391+
if (isTraceItemPending || isEventTransactionLoading) {
392392
return <LoadingIndicator />;
393393
}
394394

@@ -403,8 +403,8 @@ function EAPSpanNodeDetails({
403403
? 1
404404
: undefined;
405405

406-
const isTransaction = isEAPTransactionNode(node);
407-
const profileMeta = getProfileMeta(eventTransaction) || '';
406+
const isTransaction = isEAPTransactionNode(node) && !!eventTransaction;
407+
const profileMeta = eventTransaction ? getProfileMeta(eventTransaction) || '' : '';
408408
const profileId =
409409
typeof profileMeta === 'string' ? profileMeta : profileMeta.profiler_id;
410410

0 commit comments

Comments
 (0)