Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Feedback route should work using both project ID and Project Name #26331

Closed
donalmacc opened this issue Jun 1, 2021 · 7 comments
Closed

Comments

@donalmacc
Copy link

Summary

In the User Feedback documentation, the URL for submitting user feedback to requires specifying the project and organisation names rather than using the organisation ID and the project ID.

Motivation

This means that any application wanting to send user feedback associated with an event must provide an extra endpoint; one taht names the organisation and the project to which it pertains. If the user feedback route was of the form https://sentry.io.api/0/projects/{organization_id}/{project_id}/user-feedback/, an SDK developer would be able to form the user-feedback URL from the DSN, rather than requiring the application developer to provide a DSN and a user feedback url.

Additional Context

N/A

@BYK
Copy link
Member

BYK commented Jun 1, 2021

Possibly related: #26208.

@getsentry-release
Copy link

Routing to @getsentry/ecosystem for triage. ⏲️

@getsentry-release
Copy link

Routing to @getsentry/workflow for triage. ⏲️

@wedamija
Copy link
Member

wedamija commented Jun 1, 2021

Using org/project slug is standard across our api, we're not likely to change this.

@BYK
Copy link
Member

BYK commented Jun 2, 2021

Closing per @wedamija's answer.

@BYK BYK closed this as completed Jun 2, 2021
@untitaker
Copy link
Member

This falls into team-ingest territory. We've been aware of this problem for a while, and as a solution to this and other unrelated problems we now also have a way to submit user feedback as part of an envelope: https://develop.sentry.dev/sdk/envelopes/#user-feedback

This could probably be documented better but the point of envelopes here is that the auth/dsn/project information is sent in a unified format, there is one endpoint that can take arbitrarily many items and as a result you save on HTTP requests.

Let me know if that works for you, I'll reopen this for now.

@donalmacc
Copy link
Author

Hey untitaker, thanks for the response.

I can definitely work with the user-feedback envelope!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants