Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stack trace linking when stack frames do not contain line context. #44015

Open
rodolfoBee opened this issue Feb 2, 2023 · 3 comments

Comments

@rodolfoBee
Copy link
Member

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

Mirror of this internal issue.

  1. Implement stack trace linking as detailed here: https://docs.sentry.io/product/integrations/source-code-mgmt/github/#stack-trace-linking
  2. Send an event to Sentry that contains a stack trace but its frames do not have pre/post line context.

Expected Result

Sentry is able to provide a link to the correct file in Github.

Actual Result

No link available in the stack trace.

@getsantry
Copy link
Contributor

getsantry bot commented Feb 2, 2023

Assigning to @getsentry/support for routing, due by Thursday, February 2nd at 17:00 (yyz). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Feb 2, 2023

Routing to @getsentry/ecosystem for triage, due by Friday, February 3rd at 5:00 pm (sfo). ⏲️

@vaind
Copy link
Contributor

vaind commented Feb 15, 2023

This would be very useful for .NET source link support which should land in symbolic & symbolicator in the near future. getsentry/symbolic#735

That way, we can provide the link coming from the PortablePDB without actually fetching the source code from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants