Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crons: Consider removal of GUIDs #45328

Open
2 tasks
evanpurkhiser opened this issue Mar 2, 2023 · 2 comments
Open
2 tasks

Crons: Consider removal of GUIDs #45328

evanpurkhiser opened this issue Mar 2, 2023 · 2 comments
Assignees

Comments

@evanpurkhiser
Copy link
Member

evanpurkhiser commented Mar 2, 2023

We have now introduced custom slugs for monitor lookups (#45166).

We are currently using the monitor_id parameter in the route as way to lookup GUIDs or slugs. All existing monitors have had their guids migrated to the slugs column.

We should consider if we want to completely drop guids.

There is one primary thing holding us back from this:

  • It is difficult to use slugs in the API endpoint that does not have organization context

    POST sentry.io/api/0/monitors/:monitorGuid/checkins/
    

    Since there is no organization in the URL we would NEED to rely on the authorization method to provide the organization.

    This would NOT work with session based authorization (theoretically possible if we remember the current org). But would work OK with DNS and organization token level authentication, since those have a direct association to the organization.

Tasks

Preview Give feedback
@getsantry
Copy link
Contributor

getsantry bot commented Mar 2, 2023

Routing to @getsentry/crons for triage, due by Monday, March 6th at 11:42 am (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Sep 7, 2023

Routing to @getsentry/product-owners-crons for triage ⏲️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants