Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Default scrubbers] Safe fields behaviour #45668

Closed
masinette opened this issue Mar 10, 2023 · 6 comments
Closed

[Default scrubbers] Safe fields behaviour #45668

masinette opened this issue Mar 10, 2023 · 6 comments
Assignees
Labels
Sync: Jira Apply to auto-create a Jira shadow ticket

Comments

@masinette
Copy link
Member

masinette commented Mar 10, 2023

Environment

SaaS (https://sentry.io/)

Version

No response

Link

No response

DSN

No response

Steps to Reproduce

Adding "user.id" to the project Safe Field, but it is still filtered.

I tested on my account an only got the wanted result when using "user.id" and "user" together.
I tried these values separately and in combination with one another in the Safe Field: user, id and user.id.

Steps to reproduce:

  1. Create a test event by setting the user.id to sensitive string: Sentry.setUser({"id":"5355849125500546"})
  2. Set safe field to id.
  3. Sent test event
  4. Check if [user.id] is filtered or not
  5. Repeat for each entry in project Safe Fields

Expected Result

The user id being filtered with "user.id" in the Safe Field.

Actual Result

┆Issue is synchronized with this Jira Improvement by Unito

@getsantry
Copy link
Contributor

getsantry bot commented Mar 10, 2023

Assigning to @getsentry/support for routing, due by Monday, March 13th at 16:49 (yyz). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 11, 2023

Routing to @getsentry/workflow for triage, due by Tuesday, March 14th at 4:25 pm (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Mar 11, 2023

Routing to @getsentry/ingest for triage, due by Tuesday, March 14th at 17:00 (vie). ⏲️

@iker-barriocanal
Copy link
Contributor

iker-barriocanal commented Mar 13, 2023

Same as ISSUE-1421.

@masinette masinette added the Sync: Jira Apply to auto-create a Jira shadow ticket label Mar 13, 2023
@Dav1dde Dav1dde self-assigned this Oct 25, 2023
@Dav1dde
Copy link
Member

Dav1dde commented Oct 25, 2023

Only id should actually whitelist the user.id field, I tried reproducing this and for me only using id actually stops the filtering any other combination (without id) has no effect.

@masinette jfyi

@Dav1dde
Copy link
Member

Dav1dde commented Oct 31, 2023

We additionally changed the safe fields syntax in getsentry/relay#2605 to support the advanced config's path expressions, this means user.id will work now as well as just id (this will match any field named id).

Please re-open or create a new issue if something else comes up or this is not actually solved.

@Dav1dde Dav1dde closed this as completed Oct 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Sync: Jira Apply to auto-create a Jira shadow ticket
Projects
None yet
Development

No branches or pull requests

8 participants