Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally send View Hierarchies to Sentry with certain events #47108

Closed
michaelchai-sentry opened this issue Apr 10, 2023 · 9 comments
Closed
Labels
Sync: Jira Apply to auto-create a Jira shadow ticket

Comments

@michaelchai-sentry
Copy link

michaelchai-sentry commented Apr 10, 2023

Problem Statement

A user reported that they would only like to send View Hierarchies for events of a certain level (i.e. only fatal events). Right now, it is a opt-in feature that allow only allows you to set it to true/false. The reasoning behind wanting this is to reduce the overhead of data sent, and that they want to cut down the noise and are only interested in View Hierarchies for certain events.

Solution Brainstorm

Add some conditional logic to this feature, such as the before send callback

┆Issue is synchronized with this Jira Improvement by Unito

@michaelchai-sentry michaelchai-sentry added the Sync: Jira Apply to auto-create a Jira shadow ticket label Apr 10, 2023
@getsantry
Copy link
Contributor

getsantry bot commented Apr 10, 2023

Assigning to @getsentry/support for routing, due by Monday, April 10th at 5:00 pm (sfo). ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Apr 10, 2023

Routing to @getsentry/team-mobile for triage, due by Wednesday, April 12th at 10:27 am (sfo). ⏲️

@mattjohnsonpint
Copy link
Contributor

The user should be able to adjust this in beforeSend. Which SDK are they using?

@philipphofmann
Copy link
Member

They have to use the hints in beforeSend, which doesn't work on Cocoa cause we don't have hints yet.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto
Copy link
Contributor

@michaelchai-sentry which platform does the user have set up?

@brustolin
Copy link
Contributor

On Cocoa this problem will be solved with getsentry/sentry-cocoa#3007

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto
Copy link
Contributor

Other platforms already support the filtering of view hierarchies and screenshots via beforeSend and Hints, only iOS is pending but there's already a ticket open getsentry/sentry-cocoa#3007
Closing this one.

@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in Mobile & Cross Platform SDK Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Sync: Jira Apply to auto-create a Jira shadow ticket
Projects
Archived in project
Development

No branches or pull requests

6 participants